Skip to content

Commit

Permalink
doc: READ_ONCE() now implies smp_barrier_depends()
Browse files Browse the repository at this point in the history
This commit updates an example in memory-barriers.txt to account for
the fact that READ_ONCE() now implies smp_barrier_depends().

Signed-off-by: Paul E. McKenney <[email protected]>
[ paulmck: Added MEMORY_BARRIER instructions from DEC Alpha from
  READ_ONCE(), per David Howells's feedback. ]
  • Loading branch information
paulmck committed Dec 4, 2017
1 parent 4fbd8d1 commit 4055594
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions Documentation/memory-barriers.txt
Original file line number Diff line number Diff line change
Expand Up @@ -227,17 +227,20 @@ There are some minimal guarantees that may be expected of a CPU:
(*) On any given CPU, dependent memory accesses will be issued in order, with
respect to itself. This means that for:

Q = READ_ONCE(P); smp_read_barrier_depends(); D = READ_ONCE(*Q);
Q = READ_ONCE(P); D = READ_ONCE(*Q);

the CPU will issue the following memory operations:

Q = LOAD P, D = LOAD *Q

and always in that order. On most systems, smp_read_barrier_depends()
does nothing, but it is required for DEC Alpha. The READ_ONCE()
is required to prevent compiler mischief. Please note that you
should normally use something like rcu_dereference() instead of
open-coding smp_read_barrier_depends().
and always in that order. However, on DEC Alpha, READ_ONCE() also
emits a memory-barrier instruction, so that a DEC Alpha CPU will
instead issue the following memory operations:

Q = LOAD P, MEMORY_BARRIER, D = LOAD *Q, MEMORY_BARRIER

Whether on DEC Alpha or not, the READ_ONCE() also prevents compiler
mischief.

(*) Overlapping loads and stores within a particular CPU will appear to be
ordered within that CPU. This means that for:
Expand Down

0 comments on commit 4055594

Please sign in to comment.