Skip to content

Commit

Permalink
test_kmod: flip INT checks to be consistent
Browse files Browse the repository at this point in the history
Most checks will check for min and then max, except the int check.  Flip
the checks to be consistent with the other code.

[[email protected]: massaged commit log]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Luis R. Rodriguez <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Jessica Yu <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Michal Marek <[email protected]>
Cc: Petr Mladek <[email protected]>
Cc: Miroslav Benes <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Eric W. Biederman <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Colin Ian King <[email protected]>
Cc: David Binderman <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Dan Carpenter authored and torvalds committed Sep 9, 2017
1 parent f520409 commit 52c270d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/test_kmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ static int test_dev_config_update_int(struct kmod_test_device *test_dev,
if (ret)
return ret;

if (new > INT_MAX || new < INT_MIN)
if (new < INT_MIN || new > INT_MAX)
return -EINVAL;

mutex_lock(&test_dev->config_mutex);
Expand Down

0 comments on commit 52c270d

Please sign in to comment.