Skip to content

Commit

Permalink
bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets
Browse files Browse the repository at this point in the history
Mips builds with BCMA host mode enabled fail in mainline and -next
with:

In file included from include/linux/bcma/bcma.h:10:0,
                 from drivers/bcma/bcma_private.h:9,
		 from drivers/bcma/main.c:8:
include/linux/bcma/bcma_driver_pci.h:218:24: error:
	field 'pci_controller' has incomplete type

Bisect points to commit d41e685 ("MIPS: Kconfig: Set default MIPS
system type as generic") as the culprit. Analysis shows that the commmit
changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn
disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only
defined if PCI_DRIVERS_LEGACY is enabled.

Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on
PCI_DRIVERS_LEGACY. Add the missing dependency.

Fixes: d41e685 ("MIPS: Kconfig: Set default MIPS system type as ...")
Cc: Matt Redfearn <[email protected]>
Cc: James Hogan <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
Reviewed-by: James Hogan <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
  • Loading branch information
groeck authored and Kalle Valo committed Jan 16, 2018
1 parent 49fdde8 commit 664eadd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/bcma/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI

config BCMA_DRIVER_PCI_HOSTMODE
bool "Driver for PCI core working in hostmode"
depends on MIPS && BCMA_DRIVER_PCI
depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
help
PCI core hostmode operation (external PCI bus).

Expand Down

0 comments on commit 664eadd

Please sign in to comment.