Skip to content

Commit

Permalink
media: imx274: Fix error handling, add MAINTAINERS entry
Browse files Browse the repository at this point in the history
Add the missing MAINTAINERS entry for imx274, fix error handling in driver
probe and unregister the correct control handler in driver remove.

Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
Sakari Ailus authored and mchehab committed Nov 30, 2017
1 parent 487cc85 commit 781b045
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
8 changes: 8 additions & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -12630,6 +12630,14 @@ S: Maintained
F: drivers/ssb/
F: include/linux/ssb/

SONY IMX274 SENSOR DRIVER
M: Leon Luo <[email protected]>
L: [email protected]
T: git git://linuxtv.org/media_tree.git
S: Maintained
F: drivers/media/i2c/imx274.c
F: Documentation/devicetree/bindings/media/i2c/imx274.txt

SONY MEMORYSTICK CARD SUPPORT
M: Alex Dubov <[email protected]>
W: http://tifmxx.berlios.de/
Expand Down
5 changes: 2 additions & 3 deletions drivers/media/i2c/imx274.c
Original file line number Diff line number Diff line change
Expand Up @@ -1770,8 +1770,7 @@ static int imx274_probe(struct i2c_client *client,
return 0;

err_ctrls:
v4l2_async_unregister_subdev(sd);
v4l2_ctrl_handler_free(sd->ctrl_handler);
v4l2_ctrl_handler_free(&imx274->ctrls.handler);
err_me:
media_entity_cleanup(&sd->entity);
err_regmap:
Expand All @@ -1788,7 +1787,7 @@ static int imx274_remove(struct i2c_client *client)
imx274_write_table(imx274, mode_table[IMX274_MODE_STOP_STREAM]);

v4l2_async_unregister_subdev(sd);
v4l2_ctrl_handler_free(sd->ctrl_handler);
v4l2_ctrl_handler_free(&imx274->ctrls.handler);
media_entity_cleanup(&sd->entity);
mutex_destroy(&imx274->lock);
return 0;
Expand Down

0 comments on commit 781b045

Please sign in to comment.