Skip to content

Commit

Permalink
selftests/bpf: use typedef'ed arrays as map values
Browse files Browse the repository at this point in the history
Convert few tests that couldn't use typedef'ed arrays due to kernel bug.

Signed-off-by: Andrii Nakryiko <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
  • Loading branch information
anakryiko authored and borkmann committed Jul 15, 2019
1 parent dd13f3c commit 8981e56
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
3 changes: 2 additions & 1 deletion tools/testing/selftests/bpf/progs/test_get_stack_rawtp.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,12 @@ struct {
* issue and avoid complicated C programming massaging.
* This is an acceptable workaround since there is one entry here.
*/
typedef __u64 raw_stack_trace_t[2 * MAX_STACK_RAWTP];
struct {
__uint(type, BPF_MAP_TYPE_PERCPU_ARRAY);
__uint(max_entries, 1);
__type(key, __u32);
__u64 (*value)[2 * MAX_STACK_RAWTP];
__type(value, raw_stack_trace_t);
} rawdata_map SEC(".maps");

SEC("tracepoint/raw_syscalls/sys_enter")
Expand Down
3 changes: 1 addition & 2 deletions tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ struct {
__uint(type, BPF_MAP_TYPE_ARRAY);
__uint(max_entries, 128);
__type(key, __u32);
/* there seems to be a bug in kernel not handling typedef properly */
struct bpf_stack_build_id (*value)[PERF_MAX_STACK_DEPTH];
__type(value, stack_trace_t);
} stack_amap SEC(".maps");

/* taken from /sys/kernel/debug/tracing/events/random/urandom_read/format */
Expand Down
2 changes: 1 addition & 1 deletion tools/testing/selftests/bpf/progs/test_stacktrace_map.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ struct {
__uint(type, BPF_MAP_TYPE_ARRAY);
__uint(max_entries, 16384);
__type(key, __u32);
__u64 (*value)[PERF_MAX_STACK_DEPTH];
__type(value, stack_trace_t);
} stack_amap SEC(".maps");

/* taken from /sys/kernel/debug/tracing/events/sched/sched_switch/format */
Expand Down

0 comments on commit 8981e56

Please sign in to comment.