Skip to content

Commit

Permalink
Revert "printk: create pr_<level> functions"
Browse files Browse the repository at this point in the history 
This reverts commit 874f9c7.

Geert Uytterhoeven reports:
 "This change seems to have an (unintendent?) side-effect.

  Before, pr_*() calls without a trailing newline characters would be
  printed with a newline character appended, both on the console and in
  the output of the dmesg command.

  After this commit, no new line character is appended, and the output
  of the next pr_*() call of the same type may be appended, like in:

    - Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000
    - Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)
    + Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)"

Joe Perches says:
 "No, that is not intentional.

  The newline handling code inside vprintk_emit is a bit involved and
  for now I suggest a revert until this has all the same behavior as
  earlier"

Reported-by: Geert Uytterhoeven <[email protected]>
Requested-by: Joe Perches <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
@torvalds
torvalds committed Aug 9, 2016
1 parent 84bd8d3 commit a0cba21
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 76 deletions.
48 changes: 15 additions & 33 deletions include/linux/printk.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -266,39 +266,21 @@ extern asmlinkage void dump_stack(void) __cold;
* and other debug macros are compiled out unless either DEBUG is defined
* or CONFIG_DYNAMIC_DEBUG is set.
*/

#ifdef CONFIG_PRINTK

asmlinkage __printf(1, 2) __cold void __pr_emerg(const char *fmt, ...);
asmlinkage __printf(1, 2) __cold void __pr_alert(const char *fmt, ...);
asmlinkage __printf(1, 2) __cold void __pr_crit(const char *fmt, ...);
asmlinkage __printf(1, 2) __cold void __pr_err(const char *fmt, ...);
asmlinkage __printf(1, 2) __cold void __pr_warn(const char *fmt, ...);
asmlinkage __printf(1, 2) __cold void __pr_notice(const char *fmt, ...);
asmlinkage __printf(1, 2) __cold void __pr_info(const char *fmt, ...);

#define pr_emerg(fmt, ...) __pr_emerg(pr_fmt(fmt), ##__VA_ARGS__)
#define pr_alert(fmt, ...) __pr_alert(pr_fmt(fmt), ##__VA_ARGS__)
#define pr_crit(fmt, ...) __pr_crit(pr_fmt(fmt), ##__VA_ARGS__)
#define pr_err(fmt, ...) __pr_err(pr_fmt(fmt), ##__VA_ARGS__)
#define pr_warn(fmt, ...) __pr_warn(pr_fmt(fmt), ##__VA_ARGS__)
#define pr_notice(fmt, ...) __pr_notice(pr_fmt(fmt), ##__VA_ARGS__)
#define pr_info(fmt, ...) __pr_info(pr_fmt(fmt), ##__VA_ARGS__)

#else

#define pr_emerg(fmt, ...) printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__)
#define pr_alert(fmt, ...) printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
#define pr_crit(fmt, ...) printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__)
#define pr_err(fmt, ...) printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
#define pr_warn(fmt, ...) printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
#define pr_notice(fmt, ...) printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
#define pr_info(fmt, ...) printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)

#endif

#define pr_warning pr_warn

#define pr_emerg(fmt, ...) \
printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__)
#define pr_alert(fmt, ...) \
printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
#define pr_crit(fmt, ...) \
printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__)
#define pr_err(fmt, ...) \
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
#define pr_warning(fmt, ...) \
printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
#define pr_warn pr_warning
#define pr_notice(fmt, ...) \
printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
#define pr_info(fmt, ...) \
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
/*
* Like KERN_CONT, pr_cont() should only be used when continuing
* a line with no newline ('\n') enclosed. Otherwise it defaults
Expand Down
16 changes: 6 additions & 10 deletions kernel/printk/internal.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
*/
#include <linux/percpu.h>

typedef __printf(2, 0) int (*printk_func_t)(int level, const char *fmt,
va_list args);
typedef __printf(1, 0) int (*printk_func_t)(const char *fmt, va_list args);

__printf(2, 0)
int vprintk_default(int level, const char *fmt, va_list args);
int __printf(1, 0) vprintk_default(const char *fmt, va_list args);

#ifdef CONFIG_PRINTK_NMI

Expand All @@ -33,10 +31,9 @@ extern raw_spinlock_t logbuf_lock;
* via per-CPU variable.
*/
DECLARE_PER_CPU(printk_func_t, printk_func);
__printf(2, 0)
static inline int vprintk_func(int level, const char *fmt, va_list args)
static inline __printf(1, 0) int vprintk_func(const char *fmt, va_list args)
{
return this_cpu_read(printk_func)(level, fmt, args);
return this_cpu_read(printk_func)(fmt, args);
}

extern atomic_t nmi_message_lost;
Expand All @@ -47,10 +44,9 @@ static inline int get_nmi_message_lost(void)

#else /* CONFIG_PRINTK_NMI */

__printf(2, 0)
static inline int vprintk_func(int level, const char *fmt, va_list args)
static inline __printf(1, 0) int vprintk_func(const char *fmt, va_list args)
{
return vprintk_default(level, fmt, args);
return vprintk_default(fmt, args);
}

static inline int get_nmi_message_lost(void)
Expand Down
13 changes: 2 additions & 11 deletions kernel/printk/nmi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ static DEFINE_PER_CPU(struct nmi_seq_buf, nmi_print_seq);
* one writer running. But the buffer might get flushed from another
* CPU, so we need to be careful.
*/
static int vprintk_nmi(int level, const char *fmt, va_list args)
static int vprintk_nmi(const char *fmt, va_list args)
{
struct nmi_seq_buf *s = this_cpu_ptr(&nmi_print_seq);
int add = 0;
Expand All @@ -79,16 +79,7 @@ static int vprintk_nmi(int level, const char *fmt, va_list args)
if (!len)
smp_rmb();

if (level != LOGLEVEL_DEFAULT) {
add = snprintf(s->buffer + len, sizeof(s->buffer) - len,
KERN_SOH "%c", '0' + level);
add += vsnprintf(s->buffer + len + add,
sizeof(s->buffer) - len - add,
fmt, args);
} else {
add = vsnprintf(s->buffer + len, sizeof(s->buffer) - len,
fmt, args);
}
add = vsnprintf(s->buffer + len, sizeof(s->buffer) - len, fmt, args);

/*
* Do it once again if the buffer has been flushed in the meantime.
Expand Down
25 changes: 3 additions & 22 deletions kernel/printk/printk.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1930,26 +1930,7 @@ asmlinkage int printk_emit(int facility, int level,
}
EXPORT_SYMBOL(printk_emit);

#define define_pr_level(func, loglevel) \
asmlinkage __visible void func(const char *fmt, ...) \
{ \
va_list args; \
\
va_start(args, fmt); \
vprintk_default(loglevel, fmt, args); \
va_end(args); \
} \
EXPORT_SYMBOL(func)

define_pr_level(__pr_emerg, LOGLEVEL_EMERG);
define_pr_level(__pr_alert, LOGLEVEL_ALERT);
define_pr_level(__pr_crit, LOGLEVEL_CRIT);
define_pr_level(__pr_err, LOGLEVEL_ERR);
define_pr_level(__pr_warn, LOGLEVEL_WARNING);
define_pr_level(__pr_notice, LOGLEVEL_NOTICE);
define_pr_level(__pr_info, LOGLEVEL_INFO);

int vprintk_default(int level, const char *fmt, va_list args)
int vprintk_default(const char *fmt, va_list args)
{
int r;

Expand All @@ -1959,7 +1940,7 @@ int vprintk_default(int level, const char *fmt, va_list args)
return r;
}
#endif
r = vprintk_emit(0, level, NULL, 0, fmt, args);
r = vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, 0, fmt, args);

return r;
}
Expand Down Expand Up @@ -1992,7 +1973,7 @@ asmlinkage __visible int printk(const char *fmt, ...)
int r;

va_start(args, fmt);
r = vprintk_func(LOGLEVEL_DEFAULT, fmt, args);
r = vprintk_func(fmt, args);
va_end(args);

return r;
Expand Down

0 comments on commit a0cba21

Please sign in to comment.