Skip to content

Commit

Permalink
net: dcb: fix small regression in __dcbnl_pg_setcfg()
Browse files Browse the repository at this point in the history
A small regression was introduced in the reply command of
dcbnl_pg_setcfg(). User space apps may be expecting the
DCB_ATTR_PG_CFG attribute to be returned with the patch
below TX or RX variants are returned.

commit 7be9941
Author: Thomas Graf <[email protected]>
Date:   Wed Jun 13 02:54:55 2012 +0000

    dcbnl: Shorten all command handling functions

This patch reverts this behavior and returns DCB_ATTR_PG_CFG

Signed-off-by: John Fastabend <[email protected]>
Acked-by: Thomas Graf <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
John Fastabend authored and davem330 committed Jun 21, 2012
1 parent f73332f commit bb1dfef
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/dcb/dcbnl.c
Original file line number Diff line number Diff line change
Expand Up @@ -852,8 +852,7 @@ static int __dcbnl_pg_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
}
}

return nla_put_u8(skb,
(dir ? DCB_CMD_PGRX_SCFG : DCB_CMD_PGTX_SCFG), 0);
return nla_put_u8(skb, DCB_ATTR_PG_CFG, 0);
}

static int dcbnl_pgtx_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
Expand Down

0 comments on commit bb1dfef

Please sign in to comment.