Skip to content

Commit

Permalink
z3fold: fix sheduling while atomic
Browse files Browse the repository at this point in the history
kmem_cache_alloc() may be called from z3fold_alloc() in atomic context, so
we need to pass correct gfp flags to avoid "scheduling while atomic" bug.

Link: http://lkml.kernel.org/r/[email protected]
Fixes: 7c2b8ba ("mm/z3fold.c: add structure for buddy handles")
Signed-off-by: Vitaly Wool <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
vwool authored and torvalds committed Jun 1, 2019
1 parent ef7a77c commit bb9f6f6
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions mm/z3fold.c
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,11 @@ static int size_to_chunks(size_t size)

static void compact_page_work(struct work_struct *w);

static inline struct z3fold_buddy_slots *alloc_slots(struct z3fold_pool *pool)
static inline struct z3fold_buddy_slots *alloc_slots(struct z3fold_pool *pool,
gfp_t gfp)
{
struct z3fold_buddy_slots *slots = kmem_cache_alloc(pool->c_handle,
GFP_KERNEL);
gfp);

if (slots) {
memset(slots->slot, 0, sizeof(slots->slot));
Expand Down Expand Up @@ -295,10 +296,10 @@ static void z3fold_unregister_migration(struct z3fold_pool *pool)

/* Initializes the z3fold header of a newly allocated z3fold page */
static struct z3fold_header *init_z3fold_page(struct page *page,
struct z3fold_pool *pool)
struct z3fold_pool *pool, gfp_t gfp)
{
struct z3fold_header *zhdr = page_address(page);
struct z3fold_buddy_slots *slots = alloc_slots(pool);
struct z3fold_buddy_slots *slots = alloc_slots(pool, gfp);

if (!slots)
return NULL;
Expand Down Expand Up @@ -912,7 +913,7 @@ static int z3fold_alloc(struct z3fold_pool *pool, size_t size, gfp_t gfp,
if (!page)
return -ENOMEM;

zhdr = init_z3fold_page(page, pool);
zhdr = init_z3fold_page(page, pool, gfp);
if (!zhdr) {
__free_page(page);
return -ENOMEM;
Expand Down

0 comments on commit bb9f6f6

Please sign in to comment.