Skip to content

Commit

Permalink
ASoC: hdac_hdmi: Add support for multiple ports to a PCM
Browse files Browse the repository at this point in the history 
Since we have the MST feature enabled and Pin-Port mux for user to
select the converter routing, multiple port mapping to same converter
needs to be supported.

To support multiple port mapped to same converter following changes are
done for this:.
o Add port list to pcm, so that multiple ports can be mapped to a PCM.
o Jack reporting in case where multiple port are attached to same PCM.
o Change hdac_hdmi_get_port_from_cvt(), channel_map, remove functions
to parse through all ports mapped to same the PCM.

Signed-off-by: Jeeja KP <[email protected]>
Acked-by: Vinod Koul <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
  • Loading branch information
@kpjeeja @broonie
kpjeeja authored and broonie committed Feb 16, 2017
1 parent 1b46ebd commit e0e5d3e
Showing 1 changed file with 113 additions and 55 deletions.
168 changes: 113 additions & 55 deletions sound/soc/codecs/hdac_hdmi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ struct hdac_hdmi_pin {
};

struct hdac_hdmi_port {
struct list_head head;
int id;
struct hdac_hdmi_pin *pin;
int num_mux_nids;
Expand All @@ -99,7 +100,7 @@ struct hdac_hdmi_port {
struct hdac_hdmi_pcm {
struct list_head head;
int pcm_id;
struct hdac_hdmi_port *port;
struct list_head port_list;
struct hdac_hdmi_cvt *cvt;
struct snd_jack *jack;
int stream_tag;
Expand All @@ -108,6 +109,7 @@ struct hdac_hdmi_pcm {
bool chmap_set;
unsigned char chmap[8]; /* ALSA API channel-map */
struct mutex lock;
int jack_event;
};

struct hdac_hdmi_dai_port_map {
Expand Down Expand Up @@ -142,6 +144,37 @@ hdac_hdmi_get_pcm_from_cvt(struct hdac_hdmi_priv *hdmi,
return pcm;
}

static void hdac_hdmi_jack_report(struct hdac_hdmi_pcm *pcm,
struct hdac_hdmi_port *port, bool is_connect)
{
struct hdac_ext_device *edev = port->pin->edev;

if (is_connect) {
/*
* Report Jack connect event when a device is connected
* for the first time where same PCM is attached to multiple
* ports.
*/
if (pcm->jack_event == 0) {
dev_dbg(&edev->hdac.dev,
"jack report for pcm=%d\n",
pcm->pcm_id);
snd_jack_report(pcm->jack, SND_JACK_AVOUT);
}
pcm->jack_event++;
} else {
/*
* Report Jack disconnect event when a device is disconnected
* is the only last connected device when same PCM is attached
* to multiple ports.
*/
if (pcm->jack_event == 1)
snd_jack_report(pcm->jack, 0);
if (pcm->jack_event > 0)
pcm->jack_event--;
}
}

/* MST supported verbs */
/*
* Get the no devices that can be connected to a port on the Pin widget.
Expand Down Expand Up @@ -484,19 +517,24 @@ static struct hdac_hdmi_port *hdac_hdmi_get_port_from_cvt(

list_for_each_entry(pcm, &hdmi->pcm_list, head) {
if (pcm->cvt == cvt) {
port = pcm->port;
break;
}
}

if (port) {
ret = hdac_hdmi_query_port_connlist(edev, port->pin, port);
if (ret < 0)
return NULL;
if (list_empty(&pcm->port_list))
continue;

for (i = 0; i < port->num_mux_nids; i++) {
if (port->mux_nids[i] == cvt->nid)
return port;
list_for_each_entry(port, &pcm->port_list, head) {
mutex_lock(&pcm->lock);
ret = hdac_hdmi_query_port_connlist(edev,
port->pin, port);
mutex_unlock(&pcm->lock);
if (ret < 0)
continue;

for (i = 0; i < port->num_mux_nids; i++) {
if (port->mux_nids[i] == cvt->nid &&
port->eld.monitor_present &&
port->eld.eld_valid)
return port;
}
}
}
}

Expand Down Expand Up @@ -529,7 +567,6 @@ static int hdac_hdmi_pcm_open(struct snd_pcm_substream *substream,
*/
if (!port)
return 0;

if ((!port->eld.monitor_present) ||
(!port->eld.eld_valid)) {

Expand Down Expand Up @@ -645,13 +682,16 @@ static struct hdac_hdmi_pcm *hdac_hdmi_get_pcm(struct hdac_ext_device *edev,
{
struct hdac_hdmi_priv *hdmi = edev->private_data;
struct hdac_hdmi_pcm *pcm = NULL;
struct hdac_hdmi_port *p;

list_for_each_entry(pcm, &hdmi->pcm_list, head) {
if (!pcm->port)
if (list_empty(&pcm->port_list))
continue;

if (pcm->port == port)
return pcm;
list_for_each_entry(p, &pcm->port_list, head) {
if (p->id == port->id && port->pin == p->pin)
return pcm;
}
}

return NULL;
Expand Down Expand Up @@ -802,6 +842,7 @@ static int hdac_hdmi_set_pin_port_mux(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
int ret;
struct hdac_hdmi_port *p, *p_next;
struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
struct snd_soc_dapm_widget *w = snd_soc_dapm_kcontrol_widget(kcontrol);
struct snd_soc_dapm_context *dapm = w->dapm;
Expand All @@ -820,25 +861,30 @@ static int hdac_hdmi_set_pin_port_mux(struct snd_kcontrol *kcontrol,

mutex_lock(&hdmi->pin_mutex);
list_for_each_entry(pcm, &hdmi->pcm_list, head) {
if (!pcm->port && pcm->port == port &&
pcm->port->id == port->id)
pcm->port = NULL;
if (list_empty(&pcm->port_list))
continue;

/*
* Jack status is not reported during device probe as the
* PCMs are not registered by then. So report it here.
*/
if (!strcmp(cvt_name, pcm->cvt->name) && !pcm->port) {
pcm->port = port;
if (port->eld.monitor_present && port->eld.eld_valid) {
dev_dbg(&edev->hdac.dev,
"jack report for pcm=%d\n",
pcm->pcm_id);
list_for_each_entry_safe(p, p_next, &pcm->port_list, head) {
if (p == port && p->id == port->id &&
p->pin == port->pin) {
hdac_hdmi_jack_report(pcm, port, false);
list_del(&p->head);
}
}
}

snd_jack_report(pcm->jack, SND_JACK_AVOUT);
/*
* Jack status is not reported during device probe as the
* PCMs are not registered by then. So report it here.
*/
list_for_each_entry(pcm, &hdmi->pcm_list, head) {
if (!strcmp(cvt_name, pcm->cvt->name)) {
list_add_tail(&port->head, &pcm->port_list);
if (port->eld.monitor_present && port->eld.eld_valid) {
hdac_hdmi_jack_report(pcm, port, true);
mutex_unlock(&hdmi->pin_mutex);
return ret;
}
mutex_unlock(&hdmi->pin_mutex);
return ret;
}
}
mutex_unlock(&hdmi->pin_mutex);
Expand Down Expand Up @@ -1186,33 +1232,24 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin,

if (!port->eld.monitor_present || !port->eld.eld_valid) {

dev_dbg(&edev->hdac.dev, "%s: disconnect for pin:port %d:%d\n",
dev_err(&edev->hdac.dev, "%s: disconnect for pin:port %d:%d\n",
__func__, pin->nid, port->id);

/*
* PCMs are not registered during device probe, so don't
* report jack here. It will be done in usermode mux
* control select.
*/
if (pcm) {
dev_dbg(&edev->hdac.dev,
"jack report for pcm=%d\n", pcm->pcm_id);

snd_jack_report(pcm->jack, 0);
}
if (pcm)
hdac_hdmi_jack_report(pcm, port, false);

mutex_unlock(&hdmi->pin_mutex);
return;
}

if (port->eld.monitor_present && port->eld.eld_valid) {
if (pcm) {
dev_dbg(&edev->hdac.dev,
"jack report for pcm=%d\n",
pcm->pcm_id);

snd_jack_report(pcm->jack, SND_JACK_AVOUT);
}
if (pcm)
hdac_hdmi_jack_report(pcm, port, true);

print_hex_dump_debug("ELD: ", DUMP_PREFIX_OFFSET, 16, 1,
port->eld.eld_buffer, port->eld.eld_size, false);
Expand Down Expand Up @@ -1540,8 +1577,9 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device)
return -ENOMEM;
pcm->pcm_id = device;
pcm->cvt = hdmi->dai_map[dai->id].cvt;
pcm->jack_event = 0;
mutex_init(&pcm->lock);

INIT_LIST_HEAD(&pcm->port_list);
snd_pcm = hdac_hdmi_get_pcm_from_id(dai->component->card, device);
if (snd_pcm) {
err = snd_hdac_add_chmap_ctls(snd_pcm, device, &hdmi->chmap);
Expand Down Expand Up @@ -1716,13 +1754,17 @@ static void hdac_hdmi_set_chmap(struct hdac_device *hdac, int pcm_idx,
struct hdac_ext_device *edev = to_ehdac_device(hdac);
struct hdac_hdmi_priv *hdmi = edev->private_data;
struct hdac_hdmi_pcm *pcm = get_hdmi_pcm_from_id(hdmi, pcm_idx);
struct hdac_hdmi_port *port = pcm->port;
struct hdac_hdmi_port *port;

if (list_empty(&pcm->port_list))
return;

mutex_lock(&pcm->lock);
pcm->chmap_set = true;
memcpy(pcm->chmap, chmap, ARRAY_SIZE(pcm->chmap));
if (prepared)
hdac_hdmi_setup_audio_infoframe(edev, pcm, port);
list_for_each_entry(port, &pcm->port_list, head)
if (prepared)
hdac_hdmi_setup_audio_infoframe(edev, pcm, port);
mutex_unlock(&pcm->lock);
}

Expand All @@ -1731,17 +1773,27 @@ static bool is_hdac_hdmi_pcm_attached(struct hdac_device *hdac, int pcm_idx)
struct hdac_ext_device *edev = to_ehdac_device(hdac);
struct hdac_hdmi_priv *hdmi = edev->private_data;
struct hdac_hdmi_pcm *pcm = get_hdmi_pcm_from_id(hdmi, pcm_idx);
struct hdac_hdmi_port *port = pcm->port;

return port ? true:false;
if (list_empty(&pcm->port_list))
return false;

return true;
}

static int hdac_hdmi_get_spk_alloc(struct hdac_device *hdac, int pcm_idx)
{
struct hdac_ext_device *edev = to_ehdac_device(hdac);
struct hdac_hdmi_priv *hdmi = edev->private_data;
struct hdac_hdmi_pcm *pcm = get_hdmi_pcm_from_id(hdmi, pcm_idx);
struct hdac_hdmi_port *port = pcm->port;
struct hdac_hdmi_port *port;

if (list_empty(&pcm->port_list))
return 0;

port = list_first_entry(&pcm->port_list, struct hdac_hdmi_port, head);

if (!port)
return 0;

if (!port || !port->eld.eld_valid)
return 0;
Expand Down Expand Up @@ -1819,13 +1871,19 @@ static int hdac_hdmi_dev_remove(struct hdac_ext_device *edev)
struct hdac_hdmi_pin *pin, *pin_next;
struct hdac_hdmi_cvt *cvt, *cvt_next;
struct hdac_hdmi_pcm *pcm, *pcm_next;
struct hdac_hdmi_port *port;
int i;

snd_soc_unregister_codec(&edev->hdac.dev);

list_for_each_entry_safe(pcm, pcm_next, &hdmi->pcm_list, head) {
pcm->cvt = NULL;
pcm->port = NULL;
if (list_empty(&pcm->port_list))
continue;

list_for_each_entry(port, &pcm->port_list, head)
port = NULL;

list_del(&pcm->head);
kfree(pcm);
}
Expand Down

0 comments on commit e0e5d3e

Please sign in to comment.