Skip to content

Commit

Permalink
[PATCH] mac80211: Defer setting of RX_FLAG_DECRYPTED.
Browse files Browse the repository at this point in the history
The decryption handlers will skip the frame if the RX_FLAG_DECRYPTED
flag is set, so the early flag setting introduced by Johannes breaks
decryption. To work around this, call the handlers first and then set
the flag.

Signed-off-by: Mattias Nissler <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
  • Loading branch information
saittam authored and David S. Miller committed Oct 10, 2007
1 parent 0654ff0 commit e2f036d
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions net/mac80211/rx.c
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,7 @@ ieee80211_rx_h_decrypt(struct ieee80211_txrx_data *rx)
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) rx->skb->data;
int keyidx;
int hdrlen;
ieee80211_txrx_result result = TXRX_DROP;
struct ieee80211_key *stakey = NULL;

/*
Expand Down Expand Up @@ -522,21 +523,22 @@ ieee80211_rx_h_decrypt(struct ieee80211_txrx_data *rx)
ieee80211_wep_is_weak_iv(rx->skb, rx->key))
rx->sta->wep_weak_iv_count++;

/* either the frame will be decrypted or dropped */
rx->u.rx.status->flag |= RX_FLAG_DECRYPTED;

switch (rx->key->conf.alg) {
case ALG_WEP:
return ieee80211_crypto_wep_decrypt(rx);
result = ieee80211_crypto_wep_decrypt(rx);
break;
case ALG_TKIP:
return ieee80211_crypto_tkip_decrypt(rx);
result = ieee80211_crypto_tkip_decrypt(rx);
break;
case ALG_CCMP:
return ieee80211_crypto_ccmp_decrypt(rx);
result = ieee80211_crypto_ccmp_decrypt(rx);
break;
}

/* not reached */
WARN_ON(1);
return TXRX_DROP;
/* either the frame has been decrypted or will be dropped */
rx->u.rx.status->flag |= RX_FLAG_DECRYPTED;

return result;
}

static void ap_sta_ps_start(struct net_device *dev, struct sta_info *sta)
Expand Down

0 comments on commit e2f036d

Please sign in to comment.