Skip to content

Commit

Permalink
openrisc: entry: Fix delay slot detection
Browse files Browse the repository at this point in the history
Use execption SR stored in pt_regs for detection, the current SR is not
correct as the handler is running after return from exception.

Also, The code that checks for a delay slot uses a flag bitmask and then
wants to check if the result is not zero.  The test it implemented was
wrong.

Correct it by changing the test to check result against non zero.

Signed-off-by: Stafford Horne <[email protected]>
  • Loading branch information
stffrdhrn committed Feb 24, 2017
1 parent 2ead7ab commit e6d20c5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/openrisc/kernel/entry.S
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ EXCEPTION_ENTRY(_data_page_fault_handler)

#else

l.mfspr r6,r0,SPR_SR // SR
l.lwz r6,PT_SR(r3) // SR
l.andi r6,r6,SPR_SR_DSX // check for delay slot exception
l.sfeqi r6,0x1 // exception happened in delay slot
l.sfne r6,r0 // exception happened in delay slot
l.bnf 7f
l.lwz r6,PT_PC(r3) // address of an offending insn

Expand Down

0 comments on commit e6d20c5

Please sign in to comment.