Skip to content

Commit

Permalink
ipx: remove all unnecessary castings on ntohl
Browse files Browse the repository at this point in the history
Apply commit e0f3631
("ipx: remove unnecessary casting on ntohl")
to all seq_printf/08lX

Inspired-by: "David S. Miller" <[email protected]>
Inspired-by: Joe Perches <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Fabian Frederick authored and davem330 committed Oct 30, 2014
1 parent f541a22 commit e7b6658
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions net/ipx/ipx_proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ static int ipx_seq_interface_show(struct seq_file *seq, void *v)
}

i = list_entry(v, struct ipx_interface, node);
seq_printf(seq, "%08lX ", (unsigned long int)ntohl(i->if_netnum));
seq_printf(seq, "%08X ", ntohl(i->if_netnum));
seq_printf(seq, "%02X%02X%02X%02X%02X%02X ",
i->if_node[0], i->if_node[1], i->if_node[2],
i->if_node[3], i->if_node[4], i->if_node[5]);
Expand Down Expand Up @@ -87,7 +87,7 @@ static int ipx_seq_route_show(struct seq_file *seq, void *v)

rt = list_entry(v, struct ipx_route, node);

seq_printf(seq, "%08lX ", (unsigned long int)ntohl(rt->ir_net));
seq_printf(seq, "%08X ", ntohl(rt->ir_net));
if (rt->ir_routed)
seq_printf(seq, "%08X %02X%02X%02X%02X%02X%02X\n",
ntohl(rt->ir_intrfc->if_netnum),
Expand Down Expand Up @@ -194,19 +194,19 @@ static int ipx_seq_socket_show(struct seq_file *seq, void *v)
s = v;
ipxs = ipx_sk(s);
#ifdef CONFIG_IPX_INTERN
seq_printf(seq, "%08lX:%02X%02X%02X%02X%02X%02X:%04X ",
(unsigned long)ntohl(ipxs->intrfc->if_netnum),
seq_printf(seq, "%08X:%02X%02X%02X%02X%02X%02X:%04X ",
ntohl(ipxs->intrfc->if_netnum),
ipxs->node[0], ipxs->node[1], ipxs->node[2], ipxs->node[3],
ipxs->node[4], ipxs->node[5], ntohs(ipxs->port));
#else
seq_printf(seq, "%08lX:%04X ", (unsigned long) ntohl(ipxs->intrfc->if_netnum),
seq_printf(seq, "%08X:%04X ", ntohl(ipxs->intrfc->if_netnum),
ntohs(ipxs->port));
#endif /* CONFIG_IPX_INTERN */
if (s->sk_state != TCP_ESTABLISHED)
seq_printf(seq, "%-28s", "Not_Connected");
else {
seq_printf(seq, "%08lX:%02X%02X%02X%02X%02X%02X:%04X ",
(unsigned long)ntohl(ipxs->dest_addr.net),
seq_printf(seq, "%08X:%02X%02X%02X%02X%02X%02X:%04X ",
ntohl(ipxs->dest_addr.net),
ipxs->dest_addr.node[0], ipxs->dest_addr.node[1],
ipxs->dest_addr.node[2], ipxs->dest_addr.node[3],
ipxs->dest_addr.node[4], ipxs->dest_addr.node[5],
Expand Down

0 comments on commit e7b6658

Please sign in to comment.