nfsd: Fix a memory scribble in the callback channel

The offset of the entry in struct rpc_version has to match the version number. Reported-by: Dave Jones <[email protected]> Fixes: 1c5876d ("sunrpc: move p_count out of struct rpc_procinfo") Signed-off-by: Trond Myklebust <[email protected]> Reported-by: Dave Jones <[email protected]> Signed-off-by: J. Bruce Fields <[email protected]>
vieko · Jul 17, 2017 · eff7936 · eff7936
1 parent 5771a8c
commit eff7936
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
@@ -720,8 +720,8 @@ static const struct rpc_version nfs_cb_version4 = {
 	.counts			= nfs4_cb_counts,
 };
 
-static const struct rpc_version *nfs_cb_version[] = {
-	&nfs_cb_version4,
+static const struct rpc_version *nfs_cb_version[2] = {
+	[1] = &nfs_cb_version4,
 };
 
 static const struct rpc_program cb_program;
@@ -795,7 +795,7 @@ static int setup_callback_client(struct nfs4_client *clp, struct nfs4_cb_conn *c
 		.saddress	= (struct sockaddr *) &conn->cb_saddr,
 		.timeout	= &timeparms,
 		.program	= &cb_program,
-		.version	= 0,
+		.version	= 1,
 		.flags		= (RPC_CLNT_CREATE_NOPING | RPC_CLNT_CREATE_QUIET),
 	};
 	struct rpc_clnt *client;