set ecc to zero for failures t/f > tmax/fmax #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #206. For methods like
Amplitude
orFrequency
, it could be challenging to detect the small oscillations in the later part of the inspiral and therefore the maximum allowed timetmax
or frequencyfmax
could be much smaller than the time/frequency near merger. Therefore, for time/frequency after tmax/fmax, eccentricity can not be measured. Ifset_failures_to_zero
is True, we set the eccentricity/mean anomaly to zero for such cases at these times/frequencies.