Skip to content

Commit

Permalink
vmxnet3: use initialized skb pointer to set hash
Browse files Browse the repository at this point in the history
The recent conversion to skb_set_hash() was incorrect. 'skb' is
uninitialized at this point.

Fixes: 0b68070 ('net: vmxnet3 calls skb_set_hash')
Signed-off-by: Michal Schmidt <[email protected]>
Acked-by: Tom Herbert <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
michich authored and davem330 committed Dec 26, 2013
1 parent 2e04ad4 commit 2c15a15
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/vmxnet3/vmxnet3_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1235,7 +1235,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
#ifdef VMXNET3_RSS
if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE &&
(adapter->netdev->features & NETIF_F_RXHASH))
skb_set_hash(skb, le32_to_cpu(rcd->rssHash),
skb_set_hash(ctx->skb,
le32_to_cpu(rcd->rssHash),
PKT_HASH_TYPE_L3);
#endif
skb_put(ctx->skb, rcd->len);
Expand Down

0 comments on commit 2c15a15

Please sign in to comment.