Skip to content

Commit

Permalink
wireless: a global static to local static improvement
Browse files Browse the repository at this point in the history
There are two improvements in this simple patch:
1. wiphy_counter is a static var only used in one function, so
   can use local static instead of global static;
2. wiphy_counter wrap handling killed one comparision;

Signed-off-by: Denis ChengRq <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
  • Loading branch information
crquan authored and linvjw committed Sep 24, 2008
1 parent acaf908 commit 638af07
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions net/wireless/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ MODULE_DESCRIPTION("wireless configuration support");
* often because we need to do it for each command */
LIST_HEAD(cfg80211_drv_list);
DEFINE_MUTEX(cfg80211_drv_mutex);
static int wiphy_counter;

/* for debugfs */
static struct dentry *ieee80211_debugfs_dir;
Expand Down Expand Up @@ -206,6 +205,8 @@ int cfg80211_dev_rename(struct cfg80211_registered_device *rdev,

struct wiphy *wiphy_new(struct cfg80211_ops *ops, int sizeof_priv)
{
static int wiphy_counter;

struct cfg80211_registered_device *drv;
int alloc_size;

Expand All @@ -222,21 +223,18 @@ struct wiphy *wiphy_new(struct cfg80211_ops *ops, int sizeof_priv)

mutex_lock(&cfg80211_drv_mutex);

drv->idx = wiphy_counter;

/* now increase counter for the next device unless
* it has wrapped previously */
if (wiphy_counter >= 0)
wiphy_counter++;

mutex_unlock(&cfg80211_drv_mutex);
drv->idx = wiphy_counter++;

if (unlikely(drv->idx < 0)) {
wiphy_counter--;
mutex_unlock(&cfg80211_drv_mutex);
/* ugh, wrapped! */
kfree(drv);
return NULL;
}

mutex_unlock(&cfg80211_drv_mutex);

/* give it a proper name */
snprintf(drv->wiphy.dev.bus_id, BUS_ID_SIZE,
PHY_NAME "%d", drv->idx);
Expand Down

0 comments on commit 638af07

Please sign in to comment.