Skip to content

Commit

Permalink
[POWERPC] PS3: Vuart: change semaphore to mutex
Browse files Browse the repository at this point in the history
A general housekeeping change of the PS3 vuart variable
vuart_bus_priv.probe_mutex from semaphore to mutex.

Signed-off-by: Geoff Levand <[email protected]>
Signed-off-by: Paul Mackerras <[email protected]>
  • Loading branch information
Geoff Levand authored and paulusmack committed Jan 25, 2008
1 parent 781749a commit c4e6752
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions drivers/ps3/ps3-vuart.c
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ static int ps3_vuart_handle_port_interrupt(struct ps3_system_bus_device *dev)
struct vuart_bus_priv {
struct ports_bmp *bmp;
unsigned int virq;
struct semaphore probe_mutex;
struct mutex probe_mutex;
int use_count;
struct ps3_system_bus_device *devices[PORT_COUNT];
} static vuart_bus_priv;
Expand Down Expand Up @@ -1015,7 +1015,7 @@ static int ps3_vuart_probe(struct ps3_system_bus_device *dev)
return -EINVAL;
}

down(&vuart_bus_priv.probe_mutex);
mutex_lock(&vuart_bus_priv.probe_mutex);

result = ps3_vuart_bus_interrupt_get();

Expand Down Expand Up @@ -1075,7 +1075,7 @@ static int ps3_vuart_probe(struct ps3_system_bus_device *dev)
goto fail_probe;
}

up(&vuart_bus_priv.probe_mutex);
mutex_unlock(&vuart_bus_priv.probe_mutex);

return result;

Expand All @@ -1088,7 +1088,7 @@ static int ps3_vuart_probe(struct ps3_system_bus_device *dev)
fail_busy:
ps3_vuart_bus_interrupt_put();
fail_setup_interrupt:
up(&vuart_bus_priv.probe_mutex);
mutex_unlock(&vuart_bus_priv.probe_mutex);
dev_dbg(&dev->core, "%s:%d: failed\n", __func__, __LINE__);
return result;
}
Expand Down Expand Up @@ -1127,15 +1127,15 @@ static int ps3_vuart_remove(struct ps3_system_bus_device *dev)

BUG_ON(!dev);

down(&vuart_bus_priv.probe_mutex);
mutex_lock(&vuart_bus_priv.probe_mutex);

dev_dbg(&dev->core, " -> %s:%d: match_id %d\n", __func__, __LINE__,
dev->match_id);

if (!dev->core.driver) {
dev_dbg(&dev->core, "%s:%d: no driver bound\n", __func__,
__LINE__);
up(&vuart_bus_priv.probe_mutex);
mutex_unlock(&vuart_bus_priv.probe_mutex);
return 0;
}

Expand All @@ -1158,7 +1158,7 @@ static int ps3_vuart_remove(struct ps3_system_bus_device *dev)
priv = NULL;

dev_dbg(&dev->core, " <- %s:%d\n", __func__, __LINE__);
up(&vuart_bus_priv.probe_mutex);
mutex_unlock(&vuart_bus_priv.probe_mutex);
return 0;
}

Expand All @@ -1178,15 +1178,15 @@ static int ps3_vuart_shutdown(struct ps3_system_bus_device *dev)

BUG_ON(!dev);

down(&vuart_bus_priv.probe_mutex);
mutex_lock(&vuart_bus_priv.probe_mutex);

dev_dbg(&dev->core, " -> %s:%d: match_id %d\n", __func__, __LINE__,
dev->match_id);

if (!dev->core.driver) {
dev_dbg(&dev->core, "%s:%d: no driver bound\n", __func__,
__LINE__);
up(&vuart_bus_priv.probe_mutex);
mutex_unlock(&vuart_bus_priv.probe_mutex);
return 0;
}

Expand All @@ -1210,7 +1210,7 @@ static int ps3_vuart_shutdown(struct ps3_system_bus_device *dev)

dev_dbg(&dev->core, " <- %s:%d\n", __func__, __LINE__);

up(&vuart_bus_priv.probe_mutex);
mutex_unlock(&vuart_bus_priv.probe_mutex);
return 0;
}

Expand All @@ -1221,7 +1221,7 @@ static int __init ps3_vuart_bus_init(void)
if (!firmware_has_feature(FW_FEATURE_PS3_LV1))
return -ENODEV;

init_MUTEX(&vuart_bus_priv.probe_mutex);
mutex_init(&vuart_bus_priv.probe_mutex);

return 0;
}
Expand Down

0 comments on commit c4e6752

Please sign in to comment.