Polish

vincentchen · Mar 6, 2017 · f5aeac3 · f5aeac3
1 parent 9fb9a67
commit f5aeac3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 17 deletions.
diff --git a/...org/springframework/boot/autoconfigure/web/EmbeddedServletContainerAutoConfiguration.java b/...org/springframework/boot/autoconfigure/web/EmbeddedServletContainerAutoConfiguration.java
@@ -134,25 +134,21 @@ public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata,
 			if (this.beanFactory == null) {
 				return;
 			}
-			if (ObjectUtils.isEmpty(this.beanFactory.getBeanNamesForType(
-					EmbeddedServletContainerCustomizerBeanPostProcessor.class, true,
-					false))) {
-				RootBeanDefinition beanDefinition = new RootBeanDefinition(
-						EmbeddedServletContainerCustomizerBeanPostProcessor.class);
-				beanDefinition.setSynthetic(true);
-				registry.registerBeanDefinition(
-						"embeddedServletContainerCustomizerBeanPostProcessor",
-						beanDefinition);
+			registerSyntheticBeanIfMissing(registry,
+					"embeddedServletContainerCustomizerBeanPostProcessor",
+					EmbeddedServletContainerCustomizerBeanPostProcessor.class);
+			registerSyntheticBeanIfMissing(registry,
+					"errorPageRegistrarBeanPostProcessor",
+					ErrorPageRegistrarBeanPostProcessor.class);
+		}
 
-			}
-			if (ObjectUtils.isEmpty(this.beanFactory.getBeanNamesForType(
-					ErrorPageRegistrarBeanPostProcessor.class, true, false))) {
-				RootBeanDefinition beanDefinition = new RootBeanDefinition(
-						ErrorPageRegistrarBeanPostProcessor.class);
+		private void registerSyntheticBeanIfMissing(BeanDefinitionRegistry registry,
+				String name, Class<?> beanClass) {
+			if (ObjectUtils.isEmpty(
+					this.beanFactory.getBeanNamesForType(beanClass, true, false))) {
+				RootBeanDefinition beanDefinition = new RootBeanDefinition(beanClass);
 				beanDefinition.setSynthetic(true);
-				registry.registerBeanDefinition("errorPageRegistrarBeanPostProcessor",
-						beanDefinition);
-
+				registry.registerBeanDefinition(name, beanDefinition);
 			}
 		}
 

diff --git a/...gframework/boot/context/embedded/EmbeddedServletContainerCustomizerBeanPostProcessor.java b/...gframework/boot/context/embedded/EmbeddedServletContainerCustomizerBeanPostProcessor.java
@@ -27,6 +27,7 @@
 import org.springframework.beans.factory.ListableBeanFactory;
 import org.springframework.beans.factory.config.BeanPostProcessor;
 import org.springframework.core.annotation.AnnotationAwareOrderComparator;
+import org.springframework.util.Assert;
 
 /**
  * {@link BeanPostProcessor} that applies all {@link EmbeddedServletContainerCustomizer}s
@@ -45,6 +46,9 @@ public class EmbeddedServletContainerCustomizerBeanPostProcessor
 
 	@Override
 	public void setBeanFactory(BeanFactory beanFactory) {
+		Assert.isInstanceOf(ListableBeanFactory.class, beanFactory,
+				"EmbeddedServletContainerCustomizerBeanPostProcessor can only be used "
+						+ "with a ListableBeanFactory");
 		this.beanFactory = (ListableBeanFactory) beanFactory;
 	}
 

diff --git a/...c/main/java/org/springframework/boot/web/servlet/ErrorPageRegistrarBeanPostProcessor.java b/...c/main/java/org/springframework/boot/web/servlet/ErrorPageRegistrarBeanPostProcessor.java
@@ -27,6 +27,7 @@
 import org.springframework.beans.factory.ListableBeanFactory;
 import org.springframework.beans.factory.config.BeanPostProcessor;
 import org.springframework.core.annotation.AnnotationAwareOrderComparator;
+import org.springframework.util.Assert;
 
 /**
  * {@link BeanPostProcessor} that applies all {@link ErrorPageRegistrar}s from the bean
@@ -45,6 +46,9 @@ public class ErrorPageRegistrarBeanPostProcessor
 
 	@Override
 	public void setBeanFactory(BeanFactory beanFactory) {
+		Assert.isInstanceOf(ListableBeanFactory.class, beanFactory,
+				"ErrorPageRegistrarBeanPostProcessor can only be used "
+						+ "with a ListableBeanFactory");
 		this.beanFactory = (ListableBeanFactory) beanFactory;
 	}