Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, libjson does not compile with MS's C compiler :(
These commits fix some of the problems. Some of the changes, for example relating to signed vs unsigned, make sense independently of MSVC, I think.
With all these changes, it still won't work in MSVC, because it does not implement support for designated initializers for arrays :( This does not seem to be on the roadmap for MSVC either, unfortunately.
Even though it still won't work in MSVC, I find it valuable to deviate as little as possible from what works on the greatest amount of compilers. Pull what you feel like, and disregard the rest, no stress :)
If the actions_map could easily be initialized in an MSVC-friendly way, I would be very grateful. I'm a bit scared of that table myself, so I don't know quite where to start if I were to change it :) I've implemented initializing it at runtime as a test, and with that final change it works nicely in MSVC.