Skip to content

Commit

Permalink
Add missing steps for cmake build (facebook#8524)
Browse files Browse the repository at this point in the history
Summary:
Some cmake and test configuration are set in pre-steps
enviroment variables. Add the missing steps.

Pull Request resolved: facebook#8524

Test Plan: CI pass

Reviewed By: siying

Differential Revision: D29682731

Pulled By: jay-zhuang

fbshipit-source-id: afda1acf6a7b76989db450442b0b27f387388b9d
  • Loading branch information
jay-zhuang authored and facebook-github-bot committed Jul 15, 2021
1 parent 803a40d commit 31193a7
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ jobs:
image: ubuntu-1604:202104-01
resource_class: 2xlarge
steps:
- checkout # check out the code in the project directory
- pre-steps
- install-gflags
- upgrade-cmake
- run: (mkdir build && cd build && cmake -DWITH_GFLAGS=1 .. && make V=1 -j20 && ctest -j20) | .circleci/cat_ignore_eagain
Expand All @@ -322,7 +322,7 @@ jobs:
image: ubuntu-2004:202104-01
resource_class: 2xlarge
steps:
- checkout # check out the code in the project directory
- pre-steps
- install-gflags
- install-benchmark
- run: (mkdir build && cd build && cmake -DWITH_GFLAGS=1 -DWITH_BENCHMARK=1 .. && make V=1 -j20 && ctest -j20 && make microbench) | .circleci/cat_ignore_eagain
Expand Down Expand Up @@ -748,12 +748,6 @@ workflows:
name: "build-windows-vs2017"
vs_year: "2017"
cmake_generator: "Visual Studio 15 Win64"
# build-windows-vs2015:
# jobs:
# - build-windows:
# name: "build-windows-vs2015"
# vs_year: "2015"
# cmake_generator: "Visual Studio 14 Win64"
build-java:
jobs:
- build-linux-java
Expand Down

0 comments on commit 31193a7

Please sign in to comment.