SAK-32221 Log exceptions in Scheduler Tool. (sakaiproject#3952)

When something goes wrong we now log the stack trace so that it’s easier to discover what’s going wrong without having to resort to a debugger.
vishu77 · Feb 22, 2017 · 8cf6f55 · 8cf6f55
1 parent bf046cf
commit 8cf6f55
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/jobscheduler/scheduler-tool/src/java/org/sakaiproject/tool/app/scheduler/SchedulerTool.java b/jobscheduler/scheduler-tool/src/java/org/sakaiproject/tool/app/scheduler/SchedulerTool.java
@@ -545,7 +545,7 @@ public int getSelectedJobRunning()
      }
      catch (Exception e)
      {
-       LOG.error("Failed to trigger job now");
+       LOG.error("Failed to trigger job now", e);
        return 2;
      }
   }
@@ -637,7 +637,7 @@ public String processCreateJob()
     }
     catch (Exception e)
     {
-      LOG.error("Failed to create job. Exception message is: " + e.getMessage());
+      LOG.error("Failed to create job.", e);
       return "error";
     }
   }
@@ -748,7 +748,7 @@ public String processSetProperties()
       }
       catch (Exception e)
       {
-          LOG.error("Failed to create job. Exception message is: " + e.getMessage());
+          LOG.error("Failed to create job.", e);
           return "error";          
       }
   }
@@ -829,7 +829,7 @@ public String processCreateTrigger()
     }
     catch (Exception e)
     {
-      LOG.error("Failed to create trigger. Exception message is: " + e.getMessage());
+      LOG.error("Failed to create trigger.", e);
       return "error";
     }
     finally
@@ -937,7 +937,7 @@ public String processSetTriggerProperties ()
       }
       catch (Exception e)
       {
-          LOG.error("Failed to create job. Exception message is: " + e.getMessage());
+          LOG.error("Failed to create job.", e);
           return "error";          
       }
 
@@ -983,7 +983,7 @@ public String processDeleteJobs()
     }
     catch (SchedulerException e)
     {
-      LOG.error("Scheduler Down");
+      LOG.error("Failed to delete jobs.", e);
     }
     processRefreshJobs();
     return "jobs";
@@ -1003,7 +1003,7 @@ public String processDeleteTriggers()
     }
     catch (SchedulerException e)
     {
-      LOG.error("Scheduler Down");
+      LOG.error("Failed to delete triggers.", e);
     }
     return "edit_triggers";
   }
@@ -1033,7 +1033,7 @@ public String processRefreshJobs()
     }
     catch (SchedulerException e)
     {
-      LOG.error("scheduler error while getting job detail");
+      LOG.error("Failed to get job details.", e);
     }
 
     // test for select all
@@ -1100,7 +1100,7 @@ public String processPrepRunJobNow()
       }
       catch (Exception e)
       {
-    	LOG.error("Failed to run job now. Exception message is: " + e.getMessage());
+    	LOG.error("Failed to run job now.", e);
         return "error";
       }
   }
@@ -1200,7 +1200,7 @@ public String processSetRunNowProperties()
       }
       catch (Exception e)
       {
-          LOG.error("Failed to trigger job now");
+          LOG.error("Failed to trigger job now", e);
           return "error";
       }
   }
@@ -1267,7 +1267,7 @@ public String processRunJobNow()
      }
      catch (Exception e)
      {
-       LOG.error("Failed to trigger job now");
+       LOG.error("Failed to trigger job now", e);
        return "error";
      }
   }