Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: CMAKE_INSTALL_FULL_LIBDIR -> CMAKE_INSTALL_FULL_LIBEXECDIR #345

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

ncaq
Copy link

@ncaq ncaq commented Jul 8, 2021

Because, It must equal GRIVE_SYNC_SH_BINARY and actual grive-sync.sh path.
I patched my gentoo overlay ebuild.
added: grive: libexec patch · ncaq/ncaq-overlay@ed3354f

Because, It must equal GRIVE_SYNC_SH_BINARY and actual grive-sync.sh path.
I patched my gentoo overlay ebuild.
[added: grive: libexec patch · ncaq/ncaq-overlay@ed3354f](ncaq/ncaq-overlay@ed3354f)
Copy link

@jankatins jankatins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (found the same problem, eventually...)

@vitalif vitalif merged commit 6901fbb into vitalif:master Nov 28, 2021
@vitalif
Copy link
Owner

vitalif commented Nov 28, 2021

Didn't actually check but if you say so :)) thanks

@ncaq ncaq deleted the fix-shell-script-path branch November 30, 2021 04:55
ncaq added a commit to ncaq/ncaq-overlay that referenced this pull request Dec 11, 2021
[fixed: CMAKE_INSTALL_FULL_LIBDIR -> CMAKE_INSTALL_FULL_LIBEXECDIR by ncaq · Pull Request #345 · vitalif/grive2](vitalif/grive2#345)
で解決されたのでパッチを当てる必要が無くなりました。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants