Fix malformed JUNIT XML with shellcheck failures

vivek · Apr 21, 2019 · 5236850 · 5236850
1 parent b1fea1b
commit 5236850
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/hack/verify-shellcheck.sh b/hack/verify-shellcheck.sh
@@ -123,6 +123,13 @@ else
   fi
 fi
 
+# if KUBE_JUNIT_REPORT_DIR is set, disable colorized output.
+# Colorized output causes malformed XML in the JUNIT report.
+SHELLCHECK_COLORIZED_OUTPUT="auto"
+if [[ -n "${KUBE_JUNIT_REPORT_DIR:-}" ]]; then
+  SHELLCHECK_COLORIZED_OUTPUT="never"
+fi
+
 # common arguments we'll pass to shellcheck
 SHELLCHECK_OPTIONS=(
   # allow following sourced files that are not specified in the command,
@@ -131,6 +138,8 @@ SHELLCHECK_OPTIONS=(
   "--external-sources"
   # include our disabled lints
   "--exclude=${SHELLCHECK_DISABLED}"
+  # set colorized output
+  "--color=${SHELLCHECK_COLORIZED_OUTPUT}"
 )
 
 # lint each script, tracking failures