Skip to content

Commit

Permalink
Fix flaky rewrites tests (scala#18165)
Browse files Browse the repository at this point in the history
Fixes scala#18164

As Vulpix runs tests in parallel, sometimes cleanup wasn't finished
before another compilation started leading to throwing exception
https://github.com/lampepfl/dotty/actions/runs/5482337258/jobs/9987578194#step:4:2966

This was probably the cause
  • Loading branch information
rochala authored Jul 7, 2023
1 parent da80053 commit 778146a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion compiler/test/dotty/tools/dotc/CompilationTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class CompilationTests {
aggregateTests(
compileFile("tests/rewrites/rewrites.scala", scala2CompatMode.and("-rewrite", "-indent")),
compileFile("tests/rewrites/rewrites3x.scala", defaultOptions.and("-rewrite", "-source", "future-migration")),
compileFile("tests/rewrites/rewrites3x.scala", defaultOptions.and("-rewrite", "-source", "future-migration", "-Xfatal-warnings")),
compileFile("tests/rewrites/rewrites3x-fatal-warnings.scala", defaultOptions.and("-rewrite", "-source", "future-migration", "-Xfatal-warnings")),
compileFile("tests/rewrites/filtering-fors.scala", defaultOptions.and("-rewrite", "-source", "3.2-migration")),
compileFile("tests/rewrites/refutable-pattern-bindings.scala", defaultOptions.and("-rewrite", "-source", "3.2-migration")),
compileFile("tests/rewrites/i8982.scala", defaultOptions.and("-indent", "-rewrite")),
Expand Down
10 changes: 10 additions & 0 deletions tests/rewrites/rewrites3x-fatal-warnings.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import scala.{collection => coll, runtime=>_, _}
import coll._

def f(xs: Int*) = xs.sum
def test =
f(List(1, 2, 3): _*)

def g = { implicit x: Int =>
x + 1
}

0 comments on commit 778146a

Please sign in to comment.