update resources datasource: allow to list all resources

docs/data-sources/resources.md

@@ -31,7 +31,7 @@ data "twingate_resources" "foo" {
 
 ### Optional
 
-- `name` (String) Returns only resources that exactly match this name.
+- `name` (String) Returns only resources that exactly match this name. If no options are passed it will return all service accounts. Only one option can be used at a time.
 - `name_contains` (String) Match when the value exist in the name of the resource.
 - `name_exclude` (String) Match when the value does not exist in the name of the resource.
 - `name_prefix` (String) The name of the resource must start with the value.

twingate/internal/client/query/groups-read.go

@@ -46,6 +46,10 @@ type StringFilterOperationInput struct {
 }
 
 func NewStringFilterOperationInput(name, filter string) *StringFilterOperationInput {
+	if filter == "" && name == "" {
+		return nil
+	}
+
 	var stringFilter StringFilterOperationInput
 
 	switch filter {

twingate/internal/provider/datasource/resources.go

@@ -87,7 +87,7 @@ func (d *resources) Schema(ctx context.Context, req datasource.SchemaRequest, re
 			},
 			attr.Name: schema.StringAttribute{
 				Optional:    true,
-				Description: "Returns only resources that exactly match this name.",
+				Description: "Returns only resources that exactly match this name. If no options are passed it will return all service accounts. Only one option can be used at a time.",
 			},
 			attr.Name + attr.FilterByRegexp: schema.StringAttribute{
 				Optional:    true,
@@ -192,7 +192,7 @@ func (d *resources) Read(ctx context.Context, req datasource.ReadRequest, resp *
 		filter = attr.FilterBySuffix
 	}
 
-	if countOptionalAttributes(data.Name, data.NameRegexp, data.NameContains, data.NameExclude, data.NamePrefix, data.NameSuffix) != 1 {
+	if countOptionalAttributes(data.Name, data.NameRegexp, data.NameContains, data.NameExclude, data.NamePrefix, data.NameSuffix) > 1 {
 		addErr(&resp.Diagnostics, ErrResourcesDatasourceShouldSetOneOptionalNameAttribute, TwingateResources)
 
 		return

twingate/internal/test/acctests/datasource/resources_test.go

@@ -267,3 +267,44 @@ func testDatasourceTwingateResourcesFilter(resourceName, networkName, name1, nam
 	}
 	`, resourceName, networkName, name1, name2, name, filter)
 }
+
+func TestAccDatasourceTwingateResourcesWithoutFilters(t *testing.T) {
+	t.Parallel()
+
+	prefix := test.Prefix()
+	resourceName := test.RandomResourceName()
+	networkName := test.RandomName()
+	theDatasource := "data.twingate_resources." + resourceName
+
+	resource.Test(t, resource.TestCase{
+		ProtoV6ProviderFactories: acctests.ProviderFactories,
+		PreCheck:                 func() { acctests.PreCheck(t) },
+		CheckDestroy:             acctests.CheckTwingateResourceDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testDatasourceTwingateResourcesAll(resourceName, networkName, prefix+"_test_app"),
+				Check: acctests.ComposeTestCheckFunc(
+					testCheckResourceAttrNotEqual(theDatasource, resourcesLen, "0"),
+				),
+			},
+		},
+	})
+}
+
+func testDatasourceTwingateResourcesAll(resourceName, networkName, name string) string {
+	return fmt.Sprintf(`
+	resource "twingate_remote_network" "%[2]s" {
+	  name = "%[2]s"
+	}
+
+	resource "twingate_resource" "%[1]s" {
+	  name = "%[3]s"
+	  address = "acc-test.com"
+	  remote_network_id = twingate_remote_network.%[2]s.id
+	}
+
+	data "twingate_resources" "%[1]s" {
+	  depends_on = [twingate_resource.%[1]s]
+	}
+	`, resourceName, networkName, name)
+}