Nulling instead of deleting in dispose().

Still waiting for an "official" recommendation from a VM guy though.
volos · Dec 23, 2012 · 2466896 · 2466896
1 parent 81dcf8b
commit 2466896
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/core/Geometry.js b/src/core/Geometry.js
@@ -742,7 +742,7 @@ THREE.Geometry.prototype = {
 
 		for ( var property in this ) {
 
-			delete this[ property ];
+			this[ property ] = null;
 
 		}
 

diff --git a/src/core/Object3D.js b/src/core/Object3D.js
@@ -355,7 +355,7 @@ THREE.Object3D.prototype = {
 
 		for ( var property in this ) {
 
-			delete this[ property ];
+			this[ property ] = null;
 
 		}
 

diff --git a/src/materials/Material.js b/src/materials/Material.js
@@ -122,7 +122,7 @@ THREE.Material.prototype.dispose = function () {
 
 	for ( var property in this ) {
 
-		delete this[ property ];
+		this[ property ] = null;
 
 	}
 

diff --git a/src/textures/Texture.js b/src/textures/Texture.js
@@ -83,7 +83,7 @@ THREE.Texture.prototype = {
 
 		for ( var property in this ) {
 
-			delete this[ property ];
+			this[ property ] = null;
 
 		}
-Original file line number
+Diff line change
@@ Expand Up / @@ -742,7 +742,7 @@ THREE.Geometry.prototype = { @@
     		for ( var property in this ) {
-    			delete this[ property ];
+    			this[ property ] = null;
     		}
@@ Expand Down @@