Enable the unconvert linter.

Update the code according to the linter rules.

.golangci.yaml

@@ -33,7 +33,7 @@ linters:
     #- thelper
     #- tparallel
     - typecheck
-    #- unconvert
+    - unconvert
     - unparam
     - unused
     - varcheck

core/logger/logger.go

@@ -78,7 +78,7 @@ type LogOption func(*zap.Config)
 // WithLogLevel will set the log level on the Logger Config
 func WithLogLevel(l zapcore.Level) LogOption {
 	return func(c *zap.Config) {
-		c.Level = zap.NewAtomicLevelAt(zapcore.Level(l))
+		c.Level = zap.NewAtomicLevelAt(l)
 	}
 }
 

pkg/services/auth/auth.go

@@ -222,12 +222,12 @@ func extractSecretPart(secret *corev1.Secret, key string) []byte {
 
 	var ok bool
 
-	data, ok = secret.Data[string(key)]
+	data, ok = secret.Data[key]
 	if !ok {
 		// StringData is a write-only field, flux generates secrets on disk with StringData
 		// Once they get applied on the cluster, Kubernetes populates Data and removes StringData.
 		// Handle this case here to be able to extract data no matter the "state" of the object.
-		data = []byte(secret.StringData[string(key)])
+		data = []byte(secret.StringData[key])
 	}
 
 	return data

pkg/testutils/testutils.go

@@ -195,7 +195,7 @@ func MakeJWToken(t *testing.T, key *rsa.PrivateKey, email string, opts ...func(m
 		Audience:  jwt.Audience{"test-service"},
 		NotBefore: jwt.NewNumericDate(notBefore),
 		IssuedAt:  jwt.NewNumericDate(notBefore),
-		Expiry:    jwt.NewNumericDate(notBefore.Add(time.Duration(maxAgeSecondsAuthCookie))),
+		Expiry:    jwt.NewNumericDate(notBefore.Add(maxAgeSecondsAuthCookie)),
 	}
 	extraClaims := map[string]any{
 		"groups":             []string{"testing"},