Update doc side menu JS to allow for external links

Author: Angela Murrell <[email protected]> Reviewers: Jagadish<[email protected]> Closes apache#679 from amurrell/master
voronenko-da · Oct 1, 2018 · 334d24e · 334d24e
1 parent 5e4ba7d
commit 334d24e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/docs/_layouts/default.html b/docs/_layouts/default.html
@@ -64,7 +64,7 @@ <h2 class="section__title section__title--sub">
           <a class="button" href="/startup/hello-samza/{{site.version}}">
             Quick Start
           </a>
-          <a class="button" href="/startup/hello-samza/{{site.version}}">
+          <a class="button" href="/case-studies/">
             Case studies
           </a>
         </div>

diff --git a/docs/js/main.new.js b/docs/js/main.new.js
@@ -276,12 +276,19 @@ var buildDocMenu = (status, body, docMenu) => {
 
 		} else if (h4Link) {
 			var h4LinkEl = document.createElement('a');
-			var linkDestination = docMenuLinkBase + h4Link.getAttribute('href');
+			var h4href =h4Link.getAttribute('href');
+			var linkDestination = h4href.match(/^http/) ? h4href : docMenuLinkBase + h4href;
 			var linkText = h4Link.text.trim();
 
 			h4LinkEl.classList.add('side-navigation__group-item');
 			h4LinkEl.setAttribute('href', linkDestination);
 			h4LinkEl.setAttribute('data-match-active', h4Link.getAttribute('data-match-active'));
+
+			if (h4href.match(/^http/)) {
+				h4LinkEl.setAttribute('target', '_blank');
+				h4LinkEl.setAttribute('rel', 'nofollow');
+			}
+
 			h4LinkEl.text = linkText;
 
 			docMenu.appendChild(h4LinkEl);
@@ -302,7 +309,8 @@ var buildDocMenu = (status, body, docMenu) => {
 
 			Array.from(listItems).forEach( listItem => {
 				var link = listItem.querySelector('a');
-				linkDestination = docMenuLinkBase + link.getAttribute('href');
+				var linkhref = link.getAttribute('href');
+				linkDestination = linkhref.match(/^http/) ? linkhref : docMenuLinkBase + linkhref;
 
 				linkText = link.text.trim();
 
@@ -311,6 +319,11 @@ var buildDocMenu = (status, body, docMenu) => {
 				newLink.setAttribute('href', linkDestination);
 				newLink.text = linkText;
 
+				if (linkhref.match(/^http/)) {
+					newLink.setAttribute('target', '_blank');
+					newLink.setAttribute('rel', 'nofollow');
+				}
+
 				itemsDiv.appendChild(newLink);
 			})