Replaces a open/close to validate access with os.access in azure stor…

…ageblob. (ansible#65608)
vpvishal · Feb 5, 2020 · 3dd4b3c · 3dd4b3c
1 parent 52f2081
commit 3dd4b3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/changelogs/fragments/65608.yml b/changelogs/fragments/65608.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - azure_storageblob - use os.access to check for read rights.
diff --git a/lib/ansible/modules/cloud/azure/azure_rm_storageblob.py b/lib/ansible/modules/cloud/azure/azure_rm_storageblob.py
@@ -412,13 +412,10 @@ def download_blob(self):
     def src_is_valid(self):
         if not os.path.isfile(self.src):
             self.fail("The source path must be a file.")
-        try:
-            fp = open(self.src, 'r')
-            fp.close()
-        except IOError:
-            self.fail("Failed to access {0}. Make sure the file exists and that you have "
-                      "read access.".format(self.src))
-        return True
+        if os.access(self.src, os.R_OK):
+            return True
+        self.fail("Failed to access {0}. Make sure the file exists and that you have "
+                  "read access.".format(self.src))
 
     def dest_is_valid(self):
         if not self.check_mode:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- azure_storageblob - use os.access to check for read rights.