Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX and Performance Improvement #1122

Merged
merged 4 commits into from
Feb 9, 2025
Merged

Conversation

Map1en
Copy link
Contributor

@Map1en Map1en commented Feb 5, 2025

UI/UX Improvements

  1. Added loading indicator for group icons in UserDialog

    • Now there's a problem that the loading animation won't stop if there's a loading error.
  2. Added default size placeholder for group icons to prevent flickering

    • This helps since most players have group representation
  3. Reduced top margin in import world dialog to use space better

  4. Updated group edit mode icons in UserDialog to make top/bottom actions clearer

  5. Made favorite icon (star symbol) consistent across all areas (Same Instance)

  6. Made bio textarea taller by default

    • This helps since many player bios are longer than 5 lines (cn&jp)
  7. Added space between status icons and status text in playerList and friendsList

  8. Made friendsList table better with:

    • Header stays in place while scrolling

    • Adjusts to VRCX window size

    • Scrolls inside the table without moving the whole page

  9. Made image viewer fit window size without needing to scroll

  10. Improved launch instance dialog:

    • Better form label alignment

    • Footer fits on one line

Bug Fixes

  1. Fixed group collapse arrow rotation

    • No adaptations to material 3 themes for now
  2. Fixed Vue display-name component 'key' keyword issue

    • 'key' is a reserved word in Vue component

Performance Improvements

  1. Made feed page load faster:

    • Reduced loading time by improving el-menu default-active tab settings
      • Optimize the page transition from login to feed table display by reducing unnecessary reflow and decreasing render time by 0.3s
      • Fixed initial screen flickering
  2. Made feed table load better by separating content

  3. Added lazy loading for 'Manage Photos, Icons, Emojis and Stickers' dialog tabs

    • Destroy the dialog component when closed, to save memory
      • Not a common dialog

@Map1en Map1en mentioned this pull request Jan 27, 2025
@Natsumi-sama Natsumi-sama merged commit d73bcd0 into vrcx-team:master Feb 9, 2025
Natsumi-sama pushed a commit to Natsumi-sama/VRCX that referenced this pull request Feb 9, 2025
* wip

* wip

* ui improve and fix

* fix
@Map1en Map1en deleted the ui-improves branch February 10, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants