MDL-43979 Javascript: Correct checking of attributes during dialogue …

…init

Various dialogue attributes are optional and are provided by the parent and
not provided as attributes to the dialogue being initted.

As a result, if the setting is not provided during init, we were assuming
that the value would be false rather than checking the real attribute.

lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-debug.js

@@ -105,15 +105,15 @@ Y.extend(DIALOGUE, Y.Panel, {
      * @method initializer
      * @return void
      */
-    initializer : function(config) {
+    initializer : function() {
         var bb;
 
         if (this.get('render')) {
             this.render();
         }
         this.makeResponsive();
         this.after('visibleChange', this.visibilityChanged, this);
-        if (config.center) {
+        if (this.get('center')) {
             this.centerDialogue();
         }
         this.set('COUNT', COUNT);
@@ -126,10 +126,10 @@ Y.extend(DIALOGUE, Y.Panel, {
         // and allow setting of z-index in theme.
         bb = this.get('boundingBox');
 
-        if (config.extraClasses) {
-            Y.Array.each(config.extraClasses, bb.addClass, bb);
-        }
-        if (config.visible) {
+        // Add any additional classes that were specified.
+        Y.Array.each(this.get('extraClasses'), bb.addClass, bb);
+
+        if (this.get('visible')) {
             this.applyZIndex();
         }
         // Recalculate the zIndex every time the modal is altered.
@@ -138,7 +138,7 @@ Y.extend(DIALOGUE, Y.Panel, {
         // either by centerDialogue or makeResonsive. This is because the show() will trigger
         // a focus on the dialogue, which will scroll the page. If the dialogue has not
         // been positioned it will scroll back to the top of the page.
-        if (config.visible) {
+        if (this.get('visible')) {
             this.show();
             this.keyDelegation();
         }
@@ -567,6 +567,17 @@ Y.Base.modifyAttrs(DIALOGUE, {
     render : {
         value : true,
         writeOnce : true
+    },
+
+    /**
+     * Any additional classes to add to the boundingBox.
+     *
+     * @attributes extraClasses
+     * @type Array
+     * @default []
+     */
+    extraClasses: {
+        value: []
     }
 });
 

lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue.js

@@ -105,15 +105,15 @@ Y.extend(DIALOGUE, Y.Panel, {
      * @method initializer
      * @return void
      */
-    initializer : function(config) {
+    initializer : function() {
         var bb;
 
         if (this.get('render')) {
             this.render();
         }
         this.makeResponsive();
         this.after('visibleChange', this.visibilityChanged, this);
-        if (config.center) {
+        if (this.get('center')) {
             this.centerDialogue();
         }
         this.set('COUNT', COUNT);
@@ -126,10 +126,10 @@ Y.extend(DIALOGUE, Y.Panel, {
         // and allow setting of z-index in theme.
         bb = this.get('boundingBox');
 
-        if (config.extraClasses) {
-            Y.Array.each(config.extraClasses, bb.addClass, bb);
-        }
-        if (config.visible) {
+        // Add any additional classes that were specified.
+        Y.Array.each(this.get('extraClasses'), bb.addClass, bb);
+
+        if (this.get('visible')) {
             this.applyZIndex();
         }
         // Recalculate the zIndex every time the modal is altered.
@@ -138,7 +138,7 @@ Y.extend(DIALOGUE, Y.Panel, {
         // either by centerDialogue or makeResonsive. This is because the show() will trigger
         // a focus on the dialogue, which will scroll the page. If the dialogue has not
         // been positioned it will scroll back to the top of the page.
-        if (config.visible) {
+        if (this.get('visible')) {
             this.show();
             this.keyDelegation();
         }
@@ -565,6 +565,17 @@ Y.Base.modifyAttrs(DIALOGUE, {
     render : {
         value : true,
         writeOnce : true
+    },
+
+    /**
+     * Any additional classes to add to the boundingBox.
+     *
+     * @attributes extraClasses
+     * @type Array
+     * @default []
+     */
+    extraClasses: {
+        value: []
     }
 });
 

lib/yui/src/notification/js/dialogue.js

@@ -74,15 +74,15 @@ Y.extend(DIALOGUE, Y.Panel, {
      * @method initializer
      * @return void
      */
-    initializer : function(config) {
+    initializer : function() {
         var bb;
 
         if (this.get('render')) {
             this.render();
         }
         this.makeResponsive();
         this.after('visibleChange', this.visibilityChanged, this);
-        if (config.center) {
+        if (this.get('center')) {
             this.centerDialogue();
         }
         this.set('COUNT', COUNT);
@@ -95,10 +95,10 @@ Y.extend(DIALOGUE, Y.Panel, {
         // and allow setting of z-index in theme.
         bb = this.get('boundingBox');
 
-        if (config.extraClasses) {
-            Y.Array.each(config.extraClasses, bb.addClass, bb);
-        }
-        if (config.visible) {
+        // Add any additional classes that were specified.
+        Y.Array.each(this.get('extraClasses'), bb.addClass, bb);
+
+        if (this.get('visible')) {
             this.applyZIndex();
         }
         // Recalculate the zIndex every time the modal is altered.
@@ -107,7 +107,7 @@ Y.extend(DIALOGUE, Y.Panel, {
         // either by centerDialogue or makeResonsive. This is because the show() will trigger
         // a focus on the dialogue, which will scroll the page. If the dialogue has not
         // been positioned it will scroll back to the top of the page.
-        if (config.visible) {
+        if (this.get('visible')) {
             this.show();
             this.keyDelegation();
         }
@@ -536,6 +536,17 @@ Y.Base.modifyAttrs(DIALOGUE, {
     render : {
         value : true,
         writeOnce : true
+    },
+
+    /**
+     * Any additional classes to add to the boundingBox.
+     *
+     * @attributes extraClasses
+     * @type Array
+     * @default []
+     */
+    extraClasses: {
+        value: []
     }
 });