Updated Start.py : Added blacklisted_elements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am sure there will be more elegant ways to do this, but this seems to work. Changes: Added a list : black_listed_elements where all blacklisted items (with path, for example `blacklisted_elements = ["/webrepl_cfg.py", "/lib/microWebSrv.py"] )` Changed append to files and dirs so that there is only one pass over the elements. Earlier, the list expansion was passing over elements twice. Should be faster for large folders.
I am sure there will be more elegant ways to do this, but this seems to work. Changes: Added a list : black_listed_elements where all blacklisted items (with path, for example `blacklisted_elements = ["/webrepl_cfg.py", "/lib/microWebSrv.py"] )` Changed append to files and dirs so that there is only one pass over the elements. Earlier, the list expansion was passing over elements twice. Should be faster for large folders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sure there will be more elegant ways to do this, but this seems to work.
Changes:
Added a list : blacklisted_elements where all blacklisted items can be added (with path, for example
blacklisted_elements = ["/webrepl_cfg.py", "/lib/microWebSrv.py"] )Changed the method of append to
filesanddirsso that there is only one pass over the elements. Earlier, the list expansion was passing over elements twice. Should be faster for large folders.