Skip to content

Commit

Permalink
pytest: fix old code in test, which can cause spurious failures.
Browse files Browse the repository at this point in the history
We generated blocks to announce the channel, but it can also expire
the HTLC if the timing is wrong.  We don't need to anyway, since we
fixed the FIXME; we store local unannounced channels for restoration

Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
rustyrussell authored and cdecker committed Apr 17, 2019
1 parent 7f8e4de commit bd65567
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions tests/test_pay.py
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ def test_payment_success_persistence(node_factory, bitcoind, executor):
assert len(payments) == 1 and payments[0]['status'] == 'complete'
assert len(invoices) == 1 and invoices[0]['status'] == 'paid'

# FIXME: We should re-add pre-announced routes on startup!
bitcoind.generate_block(5)
l1.wait_channel_active(chanid)

# A duplicate should succeed immediately (nop) and return correct preimage.
Expand Down

0 comments on commit bd65567

Please sign in to comment.