Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint ternary operator error #1245

Merged
merged 2 commits into from
Sep 3, 2015
Merged

Conversation

nkovacs
Copy link

@nkovacs nkovacs commented Sep 3, 2015

eslint's operator-linebreak rule now supports the ternary operator (eslint/eslint#3274).

Changed the rule to match the code, and fixed the single instance
in the code that was different.

Changed the rule to match the code, and fixed the single instance
in the code that was different.
@nkovacs
Copy link
Author

nkovacs commented Sep 3, 2015

I don't know what's going on on circleci, it installed eslint 1.3.1, which supports this, and it works on my computer with eslint 1.3.1 (which is how I ran into this issue in the first place).

@yyx990803
Copy link
Member

It's a bit tricky here because the build setup currently uses grunt-eslint which depends on eslint ^1.1.0. So if we update the root eslint to 1.3.1, npm will install a separate copy of eslint under grunt-eslint.

I will likely update the build setup to get rid of grunt-eslint later, but for now let's stay away from altering the build setup to avoid rebase headaches from the alpha/beta branches. Thanks for raising the issue.

@yyx990803 yyx990803 closed this Sep 3, 2015
@nkovacs
Copy link
Author

nkovacs commented Sep 3, 2015

Won't grunt-eslint's ^1.1.0 install 1.3.1 though? it did that on my computer.

@yyx990803 yyx990803 reopened this Sep 3, 2015
@yyx990803
Copy link
Member

Ha, looks like it's because CircleCI used a cached version of eslint.

yyx990803 added a commit that referenced this pull request Sep 3, 2015
fix eslint ternary operator error
@yyx990803 yyx990803 merged commit 1fa16a0 into vuejs:dev Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants