fix/1601 incorrect productinfo #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarw
reviewed
Aug 20, 2018
| }) | ||
| if (option) { | ||
| results.push(option.label) | ||
| computed: { |
There was a problem hiding this comment.
Shouldn’t this logic be just in the core? I’m not sure but I think it’s duplicated in the *.vue component is kind of DRY principle violation.
Shouldn’t it be just left in the core?
There was a problem hiding this comment.
You are absolutelty right, It was originally duplicated - to make sure I'll compare both files and remove duplicated logic if there are no differences.
|
@pkarw Done, I'll check other places where we can use computed properties instead of firing events for proper reactivity working and create another PR if necessary. |
pkarw
approved these changes
Aug 21, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#1601
Short description and why it's useful
Introduced computed properies instead of non-reactive data() properies. Fixed issue with custom product attributes have not been updated correctly when navigating from one product page directly to another product page.
@pkarw Solution propsed by you doesn't work so I decided to use different approach