Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added module for clear cache after release #3650

Closed

Conversation

99percent6
Copy link

@99percent6 99percent6 commented Sep 28, 2019

Related issues

closes #

Short description and why it's useful

After the releases, we often encounter the fact that some users have spontaneous bugs or something starts to work incorrectly or the new functionality has not reached them. All these problems are resolved after cleaning localstorage, indexedDB and service worker. This module is designed specifically for such cases.

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@99percent6 99percent6 changed the title added module for clear cache after deploy Added module for clear cache after release Sep 28, 2019
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty interesting and useful feature; i really like it; however as it adds some complexity to the deployment scheme (web sockets) I’d suggest bid adding it to the core but as a separate server module that can be just disabled by the user. Please put some note on how to use it into the docs as well (“config file explained” - the source content is in the /docs)

config/default.json Outdated Show resolved Hide resolved
config/default.json Show resolved Hide resolved
core/scripts/server.ts Outdated Show resolved Hide resolved
@patzick patzick added this to the 1.11.0 milestone Sep 30, 2019
@99percent6 99percent6 requested a review from pkarw September 30, 2019 10:27
@filrak
Copy link
Collaborator

filrak commented Sep 30, 2019

Really useful one. Just please wait with merge before https://github.com/DivanteLtd/vue-storefront/pull/3651as it contains potential breaking changes. Also how about releasing it as a separate npm package @pkarw. We aim to remove all modules from src so putting something there seems redundant

@filrak
Copy link
Collaborator

filrak commented Sep 30, 2019

Really useful one. Just please wait with merge before https://github.com/DivanteLtd/vue-storefront/pull/3651as it contains potential breaking changes. Also how about releasing it as a separate npm package @pkarw. We aim to remove all modules from src so putting something there seems like adding ourselves extra work

@patzick patzick added the not ready for merge PR is holded. Needs some clarifications or things that need to be finished. label Oct 1, 2019
@pkarw pkarw modified the milestones: 1.11.0, 1.12.0-rc1 Nov 9, 2019
@andrzejewsky
Copy link
Contributor

@99percent6 what's the status of this one? Do you want to finish it?

@NicolasHofmairT23
Copy link

Hi there!

We have already implemented this PR in our project. @gibkigonzo helped us with this task.
it is working quite well.

But right now we noticed, that the "please reload" notification is always shown when you load the page initially in firefox (without any cached data. U can use inkognito tab to reproduce this). In chrome this does not happen.

You have any idea why or already know this issue?

@gibkigonzo gibkigonzo modified the milestones: 1.12.0-rc1, 1.13.0-rc1 May 21, 2020
@michhy
Copy link

michhy commented Jun 13, 2020

Hi there!

We have already implemented this PR in our project. @gibkigonzo helped us with this task.
it is working quite well.

But right now we noticed, that the "please reload" notification is always shown when you load the page initially in firefox (without any cached data. U can use inkognito tab to reproduce this). In chrome this does not happen.

You have any idea why or already know this issue?

May I know how to enable this module? I tried to put the whole folder in src/module, and add the module in src/module/index.ts, and added the definition in local.json already..

@pkarw pkarw modified the milestones: 1.13.0-rc1, Feature waitinglist Jun 19, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Fifciu
Copy link
Collaborator

Fifciu commented Dec 21, 2020

Will any of you guys finish this PR @99percent6 , @NicolasHofmairT23 , @gibkigonzo ?

@bloodf
Copy link
Contributor

bloodf commented Aug 31, 2021

This is closed due to inactivity.

If you want your PR to be re-opened, please update your files, check for any conflicts.

If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1

@bloodf bloodf closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not ready for merge PR is holded. Needs some clarifications or things that need to be finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.