-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added module for clear cache after release #3650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty interesting and useful feature; i really like it; however as it adds some complexity to the deployment scheme (web sockets) I’d suggest bid adding it to the core but as a separate server module that can be just disabled by the user. Please put some note on how to use it into the docs as well (“config file explained” - the source content is in the /docs)
Really useful one. Just please wait with merge before https://github.com/DivanteLtd/vue-storefront/pull/3651as it contains potential breaking changes. Also how about releasing it as a separate npm package @pkarw. We aim to remove all modules from src so putting something there seems redundant |
Really useful one. Just please wait with merge before https://github.com/DivanteLtd/vue-storefront/pull/3651as it contains potential breaking changes. Also how about releasing it as a separate npm package @pkarw. We aim to remove all modules from src so putting something there seems like adding ourselves extra work |
@99percent6 what's the status of this one? Do you want to finish it? |
Hi there! We have already implemented this PR in our project. @gibkigonzo helped us with this task. But right now we noticed, that the "please reload" notification is always shown when you load the page initially in firefox (without any cached data. U can use inkognito tab to reproduce this). In chrome this does not happen. You have any idea why or already know this issue? |
May I know how to enable this module? I tried to put the whole folder in src/module, and add the module in src/module/index.ts, and added the definition in local.json already.. |
|
Will any of you guys finish this PR @99percent6 , @NicolasHofmairT23 , @gibkigonzo ? |
This is closed due to inactivity. If you want your PR to be re-opened, please update your files, check for any conflicts. If your PR is for Vue Storefront 1 target the new repository at https://github.com/vuestorefront/vue-storefront-1 |
Related issues
closes #
Short description and why it's useful
After the releases, we often encounter the fact that some users have spontaneous bugs or something starts to work incorrectly or the new functionality has not reached them. All these problems are resolved after cleaning localstorage, indexedDB and service worker. This module is designed specifically for such cases.
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance