Extensions and themes splited into node packages #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Igloczek
force-pushed
the
feature/npm-modules
branch
from
52c531d to
f0548fe
Compare
Igloczek
force-pushed
the
feature/npm-modules
branch
from
643eab4 to
03d5baf
Compare
Merged
pkarw
approved these changes
Mar 21, 2018
Igloczek
commented
Mar 21, 2018
core/app.js
Outdated
| @@ -46,7 +45,15 @@ export function createApp () { | |||
| render: h => h(App) | |||
| }) | |||
|
|
|||
| registerExtensions(_.union(extensionEntryPoints, config.requiredExtensions) || [], app, router, store, config) // TODO: use config or ENV variables | |||
| // TODO: use config or ENV variables | |||
There was a problem hiding this comment.
@pkarw do you know if this TODO is still necessary here?
There was a problem hiding this comment.
Don't remember what did I mean by this :) remove it :)
|
I Will test tomorrow on Windows and Linux |
|
Works for me on Windows/ElementaryOS, merging ;) |
|
Tested on Windows 10 and works great on except v-viewer has stopped working. It was working but now seems to be hung up with SSR type problems after yarn. I verified the version didn't change so I'm not quite sure what's up with that. |
|
@jimcreate78 Could you create a new issue with some scenario to reproduce it? |
|
I will try and stage the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dropped support of
npmfor core development, b/c onlyyarnsupport workspaces (apart of other advantages)All hacks related to manually running
npmin the child folders are removed, b/c are not necessary anymore.I also introduced some very basic packages naming convention:
@vue-storefrontis the official namespace@vue-storefront/theme-*is for themes@vue-storefront/extension-*is for extensionsPackages, for now, are not published.
The whole process of splitting the codebase is not done yet, the core is still waiting.
I'm creating this PR mostly to test everything on few machines, before merging anything.