Skip to content

Commit

Permalink
Bug 28676: Cache and retrieve match_count when searching a cached hea…
Browse files Browse the repository at this point in the history
…ding

We use match_count to determine if a new authority record should be created, however,
we were not adding this count to the cache, so if a record returned too many matches on first
lookup, we would create a new record on the second lookup

To test:
1 - Set Linker Module to 'Default'
2 - Enable  AutoCreateAuthorities  and  BiblioAddsAuthorities and  CatalogModuleRelink and LinkerRelink
3 - Add two copies of a single authority via Z39
4 - Add two headings for that authority to a bib record (e.g. a 610 and 710)
5 - Save the record and note a new authority is generated
6 - Repeat and see another is generated
7 - Apply patch
8 - Restart all the things
9 - Save the record again, no new authority created

Signed-off-by: Phil Ringnalda <[email protected]>

Signed-off-by: Joonas Kylmälä <[email protected]>

Signed-off-by: Jonathan Druart <[email protected]>
  • Loading branch information
kidclamp authored and joubu committed Sep 20, 2021
1 parent ce51e2c commit ea88cfb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions C4/Linker/Default.pm
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ sub get_link {
if ( $self->{'cache'}->{$search_form.$auth_type}->{'cached'} ) {
$authid = $self->{'cache'}->{$search_form.$auth_type}->{'authid'};
$fuzzy = $self->{'cache'}->{$search_form.$auth_type}->{'fuzzy'};
$match_count = $self->{'cache'}->{$search_form.$auth_type}->{'match_count'};
}
else {

Expand Down Expand Up @@ -77,6 +78,7 @@ sub get_link {
$self->{'cache'}->{$search_form.$auth_type}->{'cached'} = 1;
$self->{'cache'}->{$search_form.$auth_type}->{'authid'} = $authid;
$self->{'cache'}->{$search_form.$auth_type}->{'fuzzy'} = $fuzzy;
$self->{'cache'}->{$search_form.$auth_type}->{'match_count'} = $match_count;
}
return $self->SUPER::_handle_auth_limit($authid), $fuzzy, $match_count;
}
Expand Down

0 comments on commit ea88cfb

Please sign in to comment.