forked from apache/hive
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HIVE-21952 : Allow unsetting of serde properties (Miklos Gergely, rev…
…iewed by David Mollitor)
- Loading branch information
1 parent
6569d58
commit 8208df9
Showing
9 changed files
with
311 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
.../org/apache/hadoop/hive/ql/ddl/table/storage/serde/AlterTableUnsetSerdePropsAnalyzer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hive.ql.ddl.table.storage.serde; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import org.apache.hadoop.hive.common.TableName; | ||
| import org.apache.hadoop.hive.ql.QueryState; | ||
| import org.apache.hadoop.hive.ql.ddl.DDLWork; | ||
| import org.apache.hadoop.hive.ql.ddl.DDLSemanticAnalyzerFactory.DDLType; | ||
| import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableAnalyzer; | ||
| import org.apache.hadoop.hive.ql.ddl.table.AlterTableType; | ||
| import org.apache.hadoop.hive.ql.exec.TaskFactory; | ||
| import org.apache.hadoop.hive.ql.parse.ASTNode; | ||
| import org.apache.hadoop.hive.ql.parse.HiveParser; | ||
| import org.apache.hadoop.hive.ql.parse.SemanticException; | ||
|
|
||
| /** | ||
| * Analyzer for unset serde properties commands. | ||
| */ | ||
| @DDLType(types = {HiveParser.TOK_ALTERTABLE_UNSETSERDEPROPERTIES, HiveParser.TOK_ALTERPARTITION_UNSETSERDEPROPERTIES}) | ||
| public class AlterTableUnsetSerdePropsAnalyzer extends AbstractAlterTableAnalyzer { | ||
| public AlterTableUnsetSerdePropsAnalyzer(QueryState queryState) throws SemanticException { | ||
| super(queryState); | ||
| } | ||
|
|
||
| @Override | ||
| protected void analyzeCommand(TableName tableName, Map<String, String> partitionSpec, ASTNode command) | ||
| throws SemanticException { | ||
| Map<String, String> props = getProps((ASTNode) (command.getChild(0)).getChild(0)); | ||
|
|
||
| AlterTableUnsetSerdePropsDesc desc = new AlterTableUnsetSerdePropsDesc(tableName, partitionSpec, props); | ||
| addInputsOutputsAlterTable(tableName, partitionSpec, desc, AlterTableType.SET_SERDE_PROPS, false); | ||
| rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(), desc))); | ||
| } | ||
| } |
46 changes: 46 additions & 0 deletions
46
...java/org/apache/hadoop/hive/ql/ddl/table/storage/serde/AlterTableUnsetSerdePropsDesc.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hive.ql.ddl.table.storage.serde; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import org.apache.hadoop.hive.common.TableName; | ||
| import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableDesc; | ||
| import org.apache.hadoop.hive.ql.ddl.table.AlterTableType; | ||
| import org.apache.hadoop.hive.ql.parse.SemanticException; | ||
| import org.apache.hadoop.hive.ql.plan.Explain; | ||
| import org.apache.hadoop.hive.ql.plan.Explain.Level; | ||
|
|
||
| /** | ||
| * DDL task description for ALTER TABLE ... UNSET SERDEPROPERTIES ... commands. | ||
| */ | ||
| @Explain(displayName = "Unset Serde Props", explainLevels = { Level.USER, Level.DEFAULT, Level.EXTENDED }) | ||
| public class AlterTableUnsetSerdePropsDesc extends AbstractAlterTableDesc { | ||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| public AlterTableUnsetSerdePropsDesc(TableName tableName, Map<String, String> partitionSpec, | ||
| Map<String, String> props) throws SemanticException { | ||
| super(AlterTableType.SET_SERDE_PROPS, tableName, partitionSpec, null, false, false, props); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean mayNeedWriteId() { | ||
| return false; | ||
| } | ||
| } |
43 changes: 43 additions & 0 deletions
43
...org/apache/hadoop/hive/ql/ddl/table/storage/serde/AlterTableUnsetSerdePropsOperation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hive.ql.ddl.table.storage.serde; | ||
|
|
||
| import org.apache.hadoop.hive.metastore.api.StorageDescriptor; | ||
| import org.apache.hadoop.hive.ql.ddl.DDLOperationContext; | ||
| import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableOperation; | ||
| import org.apache.hadoop.hive.ql.metadata.HiveException; | ||
| import org.apache.hadoop.hive.ql.metadata.Partition; | ||
| import org.apache.hadoop.hive.ql.metadata.Table; | ||
|
|
||
| /** | ||
| * Operation process of unsetting serde properties. | ||
| */ | ||
| public class AlterTableUnsetSerdePropsOperation extends AbstractAlterTableOperation<AlterTableUnsetSerdePropsDesc> { | ||
| public AlterTableUnsetSerdePropsOperation(DDLOperationContext context, AlterTableUnsetSerdePropsDesc desc) { | ||
| super(context, desc); | ||
| } | ||
|
|
||
| @Override | ||
| protected void doAlteration(Table table, Partition partition) throws HiveException { | ||
| StorageDescriptor sd = getStorageDescriptor(table, partition); | ||
| for (String key : desc.getProps().keySet()) { | ||
| sd.getSerdeInfo().getParameters().remove(key); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters