Merge pull request dexidp#1140 from ericchiang/fix-proto-build

*: fix proto build
vyshane · Dec 1, 2017 · 32257bc · 32257bc
2 parents 861d4ae + c5de6fa
commit 32257bc
Show file tree

Hide file tree

Showing 14 changed files with 5,740 additions and 86 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -25,6 +25,7 @@ install:
 script:
   - make testall
   - ./scripts/test-k8s.sh
+  - make verify-proto # Ensure proto generation doesn't depend on external packages.
 
 notifications:
   email: false
diff --git a/Makefile b/Makefile
@@ -61,14 +61,14 @@ docker-image:
 	@sudo docker build -t $(DOCKER_IMAGE) .
 
 .PHONY: proto
-proto: api/api.pb.go server/internal/types.pb.go
-
-api/api.pb.go: api/api.proto bin/protoc bin/protoc-gen-go
+proto: bin/protoc bin/protoc-gen-go
 	@./bin/protoc --go_out=plugins=grpc:. --plugin=protoc-gen-go=./bin/protoc-gen-go api/*.proto
-
-server/internal/types.pb.go: server/internal/types.proto bin/protoc bin/protoc-gen-go
 	@./bin/protoc --go_out=. --plugin=protoc-gen-go=./bin/protoc-gen-go server/internal/*.proto
 
+.PHONY: verify-proto
+verify-proto: proto
+	@./scripts/git-diff
+
 bin/protoc: scripts/get-protoc
 	@./scripts/get-protoc bin/protoc