Expand sort and filter for matches and ongoing endpoints #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
map doesn't seem to work here and filled with a lot of noise
Updated
Added sort order in addition to column
Also cleaned up the map list to only show maps that have a valid map name (handled by mmr service I think, this was also improved in a recent PR that hasn't been merged yet - should work for newer seasons at least)
Now uses the mapName property to display in ui as well as filtering in backend
This makes it possible to find finished games on a given map
Or just recent high lvl games with the mmr descending sort
