Skip to content

Commit

Permalink
contrib: make stricter shellcheck from Ubuntu 18.04 happy
Browse files Browse the repository at this point in the history
In contrib/bootstrap-node.sh line 7:
if type lightning-cli >/dev/null 2>&1; then
   ^-- SC2039: In POSIX sh, 'type' is undefined.

In contrib/startup_regtest.sh line 41:
	type lightning-cli || return
        ^-- SC2039: In POSIX sh, 'type' is undefined.

In contrib/startup_regtest.sh line 42:
	type lightningd || return
        ^-- SC2039: In POSIX sh, 'type' is undefined.

Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
rustyrussell authored and niftynei committed Aug 23, 2019
1 parent 3d85154 commit 997af6f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions contrib/bootstrap-node.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
set -e

# If lightning-cli not in their path, assume it's in subdir.
# shellcheck disable=SC2039
if type lightning-cli >/dev/null 2>&1; then
LCLI=lightning-cli
elif [ -x cli/lightning-cli ]; then
Expand Down
2 changes: 2 additions & 0 deletions contrib/startup_regtest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ fi

if [ -z "$PATH_TO_LIGHTNING" ]; then
# Already installed maybe? Prints
# shellcheck disable=SC2039
type lightning-cli || return
# shellcheck disable=SC2039
type lightningd || return
LCLI=lightning-cli
LIGHTNINGD=lightningd
Expand Down

0 comments on commit 997af6f

Please sign in to comment.