ovl: fix file leak in ovl_real_fdget_meta()

ovl_open_realfile() is wrongly called twice after conversion to new struct fd. Fixes: 88a2f64 ("struct fd: representation change") Reported-by: [email protected] Signed-off-by: Amir Goldstein <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
wafgo · Sep 27, 2024 · 0c33037 · 0c33037
1 parent 34e1a5d
commit 0c33037
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
@@ -117,7 +117,7 @@ static int ovl_real_fdget_meta(const struct file *file, struct fd *real,
 		struct file *f = ovl_open_realfile(file, &realpath);
 		if (IS_ERR(f))
 			return PTR_ERR(f);
-		real->word = (unsigned long)ovl_open_realfile(file, &realpath) | FDPUT_FPUT;
+		real->word = (unsigned long)f | FDPUT_FPUT;
 		return 0;
 	}