drm/xe: Remove extra xe_mmio_read32 from xe_mmio_wait32

Commit 7aaec3a ("drm/xe: Let's return last value read on xe_mmio_wait32.") mentions that we should return the last value read, but we never actually return it. This breaks display which depends on the value being actually returned where needed. Signed-off-by: Maarten Lankhorst <[email protected]> Cc: Rodrigo Vivi <[email protected]> Fixes: 7aaec3a ("drm/xe: Let's return last value read on xe_mmio_wait32.") Reviewed-by: Lucas De Marchi <[email protected]> Reviewed-by: Mika Kuoppala <[email protected]> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/257 Signed-off-by: Rodrigo Vivi <[email protected]>
wafgo · Dec 19, 2023 · 1bd4db3 · 1bd4db3
1 parent a9b1a13
commit 1bd4db3
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/drivers/gpu/drm/xe/xe_mmio.h b/drivers/gpu/drm/xe/xe_mmio.h
@@ -93,9 +93,6 @@ static inline int xe_mmio_wait32(struct xe_gt *gt, u32 reg, u32 val, u32 mask,
 	u32 read;
 
 	for (;;) {
-		if ((xe_mmio_read32(gt, reg) & mask) == val)
-			return 0;
-
 		read = xe_mmio_read32(gt, reg);
 		if ((read & mask) == val) {
 			ret = 0;