Skip to content

Commit

Permalink
xfs: fix dqiterate thinko
Browse files Browse the repository at this point in the history
For some unknown reason, when I converted the incore dquot objects to
store the dquot id in host endian order, I removed the increment here.
This causes the scan to stop after retrieving the root dquot, which
severely limits the usefulness of the quota scrubber.  Fix the lost
increment, though it won't fix the problem that the quota iterator code
filters out zeroed dquot records.

Fixes: c51df73 ("xfs: stop using q_core.d_id in the quota code")
Signed-off-by: "Darrick J. Wong" <[email protected]>
Reviewed-by: Dave Chinner <[email protected]>
Signed-off-by: Chandan Babu R <[email protected]>
  • Loading branch information
Darrick J. Wong authored and Chandan Babu R committed Aug 18, 2023
1 parent 220c8d5 commit 2c234a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/xfs/xfs_dquot.c
Original file line number Diff line number Diff line change
Expand Up @@ -1386,7 +1386,7 @@ xfs_qm_dqiterate(
return error;

error = iter_fn(dq, type, priv);
id = dq->q_id;
id = dq->q_id + 1;
xfs_qm_dqput(dq);
} while (error == 0 && id != 0);

Expand Down

0 comments on commit 2c234a2

Please sign in to comment.