Skip to content

Commit

Permalink
tools/firmware/ihex2fw: Simplify next record offset calculation
Browse files Browse the repository at this point in the history
We can convert original expression for 'writelen" to use ALIGN as
follows:

    (p->len + 9) & ~3 => (p->len + 6 + 3) & ~3 => ALIGN(p->len + 6, 4)

Now, subsituting "p->len + 6" with "p->len + sizeof(p->addr) +
sizeof(p->len)" we end up with the same expression as used by kernel
couterpart in linux/ihex.h:

    ALIGN(p->len + sizeof(p->addr) + sizeof(p->len), 4)

That is a full size of the record, aligned to 4 bytes. No functional
change intended.

Cc: Chris Healy <[email protected]>
Cc: Kyle McMartin <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: linux-kernel <[email protected]>
Signed-off-by: Andrey Smirnov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
ndreys authored and gregkh committed Jan 22, 2019
1 parent 9fb4ab4 commit 2ef8179
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion tools/firmware/ihex2fw.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
#include <getopt.h>


#define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask))
#define __ALIGN_KERNEL(x, a) __ALIGN_KERNEL_MASK(x, (typeof(x))(a) - 1)
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))

struct ihex_binrec {
struct ihex_binrec *next; /* not part of the real data structure */
uint32_t addr;
Expand Down Expand Up @@ -259,13 +263,18 @@ static void file_record(struct ihex_binrec *record)
*p = record;
}

static uint16_t ihex_binrec_size(struct ihex_binrec *p)
{
return p->len + sizeof(p->addr) + sizeof(p->len);
}

static int output_records(int outfd)
{
unsigned char zeroes[6] = {0, 0, 0, 0, 0, 0};
struct ihex_binrec *p = records;

while (p) {
uint16_t writelen = (p->len + 9) & ~3;
uint16_t writelen = ALIGN(ihex_binrec_size(p), 4);

p->addr = htonl(p->addr);
p->len = htons(p->len);
Expand Down

0 comments on commit 2ef8179

Please sign in to comment.