Skip to content

Commit

Permalink
fs/orangefs: remove ORANGEFS_CACHE_CREATE_FLAGS
Browse files Browse the repository at this point in the history
The flags were set to SLAB_RED_ZONE when CONFIG_DEBUG_SLAB was enabled.
With SLAB gone, this is now dead code so remove it. With SLUB, debugging
options including red zoning can be set for orangefs caches by the
slab_debug boot parameter.

Signed-off-by: Vlastimil Babka <[email protected]>
Signed-off-by: Mike Marshall <[email protected]>
  • Loading branch information
tehcaster authored and hubcapsc committed Feb 14, 2024
1 parent 841c351 commit 3635d00
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
2 changes: 1 addition & 1 deletion fs/orangefs/orangefs-cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ int op_cache_initialize(void)
op_cache = kmem_cache_create("orangefs_op_cache",
sizeof(struct orangefs_kernel_op_s),
0,
ORANGEFS_CACHE_CREATE_FLAGS,
0,
NULL);

if (!op_cache) {
Expand Down
10 changes: 0 additions & 10 deletions fs/orangefs/orangefs-kernel.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,6 @@ enum orangefs_vfs_op_states {
OP_VFS_STATE_GIVEN_UP = 16,
};

/*
* orangefs kernel memory related flags
*/

#if (defined CONFIG_DEBUG_SLAB)
#define ORANGEFS_CACHE_CREATE_FLAGS SLAB_RED_ZONE
#else
#define ORANGEFS_CACHE_CREATE_FLAGS 0
#endif

extern const struct xattr_handler * const orangefs_xattr_handlers[];

extern struct posix_acl *orangefs_get_acl(struct inode *inode, int type, bool rcu);
Expand Down
2 changes: 1 addition & 1 deletion fs/orangefs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ int orangefs_inode_cache_initialize(void)
"orangefs_inode_cache",
sizeof(struct orangefs_inode_s),
0,
ORANGEFS_CACHE_CREATE_FLAGS,
0,
offsetof(struct orangefs_inode_s,
link_target),
sizeof_field(struct orangefs_inode_s,
Expand Down

0 comments on commit 3635d00

Please sign in to comment.