Skip to content

Commit

Permalink
sysctl: Replace nr_entries with ctl_table_size in new_links
Browse files Browse the repository at this point in the history
The number of ctl_table entries (nr_entries) calculation was previously
based on the ctl_table_size and the sentinel element. Since the
sentinels have been removed, we remove the calculation and just use the
ctl_table_size from the ctl_table_header.

Signed-off-by: Joel Granados <[email protected]>
  • Loading branch information
Joelgranados committed Jun 13, 2024
1 parent d7a76ec commit 55bb7eb
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions fs/proc/proc_sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1166,27 +1166,25 @@ static struct ctl_table_header *new_links(struct ctl_dir *dir, struct ctl_table_
struct ctl_table_header *links;
struct ctl_node *node;
char *link_name;
int nr_entries, name_bytes;
int name_bytes;

name_bytes = 0;
nr_entries = 0;
list_for_each_table_entry(entry, head) {
nr_entries++;
name_bytes += strlen(entry->procname) + 1;
}

links = kzalloc(sizeof(struct ctl_table_header) +
sizeof(struct ctl_node)*nr_entries +
sizeof(struct ctl_table)*(nr_entries + 1) +
sizeof(struct ctl_node)*head->ctl_table_size +
sizeof(struct ctl_table)*(head->ctl_table_size + 1) +
name_bytes,
GFP_KERNEL);

if (!links)
return NULL;

node = (struct ctl_node *)(links + 1);
link_table = (struct ctl_table *)(node + nr_entries);
link_name = (char *)&link_table[nr_entries + 1];
link_table = (struct ctl_table *)(node + head->ctl_table_size);
link_name = (char *)&link_table[head->ctl_table_size + 1];
link = link_table;

list_for_each_table_entry(entry, head) {
Expand All @@ -1200,7 +1198,7 @@ static struct ctl_table_header *new_links(struct ctl_dir *dir, struct ctl_table_
}
init_header(links, dir->header.root, dir->header.set, node, link_table,
head->ctl_table_size);
links->nreg = nr_entries;
links->nreg = head->ctl_table_size;

return links;
}
Expand Down

0 comments on commit 55bb7eb

Please sign in to comment.