Skip to content

Commit

Permalink
OSS: dmasound/paula: Mark driver struct with __refdata to prevent sec…
Browse files Browse the repository at this point in the history
…tion mismatch

As described in the added code comment, a reference to .exit.text is ok
for drivers registered via module_platform_driver_probe(). Make this
explicit to prevent the following section mismatch warning

	WARNING: modpost: sound/oss/dmasound/dmasound_paula: section mismatch in reference: amiga_audio_driver+0x8 (section: .data) -> amiga_audio_remove (section: .exit.text)

that triggers on an allmodconfig W=1 build.

Signed-off-by: Uwe Kleine-König <[email protected]>
Message-ID: <c216a129aa88f3af5c56fe6612a472f7a882f048.1711748999.git.u.kleine-koenig@pengutronix.de>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
Uwe Kleine-König authored and tiwai committed Apr 1, 2024
1 parent c33f0d4 commit 755795c
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion sound/oss/dmasound/dmasound_paula.c
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,13 @@ static void __exit amiga_audio_remove(struct platform_device *pdev)
dmasound_deinit();
}

static struct platform_driver amiga_audio_driver = {
/*
* amiga_audio_remove() lives in .exit.text. For drivers registered via
* module_platform_driver_probe() this is ok because they cannot get unbound at
* runtime. So mark the driver struct with __refdata to prevent modpost
* triggering a section mismatch warning.
*/
static struct platform_driver amiga_audio_driver __refdata = {
.remove_new = __exit_p(amiga_audio_remove),
.driver = {
.name = "amiga-audio",
Expand Down

0 comments on commit 755795c

Please sign in to comment.