xfrm: Allow UDP encapsulation only in offload modes

The missing check of x->encap caused to the situation where GSO packets were created with UDP encapsulation. As a solution return the encap check for non-offloaded SA. Fixes: 983a73d ("xfrm: Pass UDP encapsulation in TX packet offload") Closes: https://lore.kernel.org/all/[email protected] Reported-by: Paolo Abeni <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]> Signed-off-by: Steffen Klassert <[email protected]>
wafgo · Mar 18, 2024 · 773bb76 · 773bb76
1 parent c319882
commit 773bb76
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
@@ -407,7 +407,8 @@ bool xfrm_dev_offload_ok(struct sk_buff *skb, struct xfrm_state *x)
 	struct xfrm_dst *xdst = (struct xfrm_dst *)dst;
 	struct net_device *dev = x->xso.dev;
 
-	if (!x->type_offload)
+	if (!x->type_offload ||
+	    (x->xso.type == XFRM_DEV_OFFLOAD_UNSPECIFIED && x->encap))
 		return false;
 
 	if (x->xso.type == XFRM_DEV_OFFLOAD_PACKET ||